Skip to content

MADE TODO: fix/kplib rename to knowledge_schema and update imports#212

Merged
gvanrossum merged 1 commit intomicrosoft:mainfrom
ANGELUSD11:fix/kplib-rename
Mar 4, 2026
Merged

MADE TODO: fix/kplib rename to knowledge_schema and update imports#212
gvanrossum merged 1 commit intomicrosoft:mainfrom
ANGELUSD11:fix/kplib-rename

Conversation

@ANGELUSD11
Copy link
Contributor

  • [P3, small] Rename kplib.py to something ending in _schema.py

Summary
Renamed kplib.py to knowledge_schema.py to make the filename more descriptive of its purpose as a schema definition file for knowledge extraction. Maintained compatibility by using as kplib alias in all imports.

Verification
✅ All tests pass successfully (make test)

Motivation
This change addresses the TODO item: "[P3, small] Rename kplib.py to something ending in _schema.py" . The new name knowledge_schema.py better reflects that the file contains schema definitions for knowledge extraction (entities, actions, topics, etc.) kplib.py:1-8 .

Compatibility
Full compatibility is maintained using the as kplib alias, so existing code using kplib. continues to work without changes.

@ANGELUSD11
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Collaborator

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you used AI to generate this change. There's nothing wrong with that (I use it too after all), but don't claim you're now a contributor. :-)

@gvanrossum gvanrossum merged commit 29f68bb into microsoft:main Mar 4, 2026
16 checks passed
@ANGELUSD11
Copy link
Contributor Author

I only used it for the commit message and PR, but thank you, I admire you a lot. :)

@gvanrossum
Copy link
Collaborator

Okay great! Looking forward to more PRs from you. Just maybe don't copy-paste the AI output -- write it yourself. (I will fix mistakes in the description before I merge the commit.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants