Fix missing tsc.js in command args for non-native tsc benchmarks#121
Merged
jakebailey merged 1 commit intomainfrom Apr 19, 2026
Merged
Conversation
In runCompilerScenario, when building with a non-native host (e.g., node@18.15.0), the path to tsc.js was never added to the command line arguments. This resulted in running: node --expose-gc -b /path/to/suite/... --diagnostics instead of: node --expose-gc /path/to/tsc.js -b /path/to/suite/... --diagnostics The same fix is applied to the clean command builder. Agent-Logs-Url: https://github.com/microsoft/typescript-benchmarking/sessions/a7bef415-e1eb-4b1d-bb7e-57c06390d9d5 Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jakebailey
April 19, 2026 12:41
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-tsgo tsc benchmarks fail immediately because
tsc.jsis never added to the node command line. The resulting command isnode --expose-gc -b /path/to/suite/... --diagnosticsinstead ofnode --expose-gc /path/to/tsc.js -b /path/to/suite/... --diagnostics.The tsgo refactor split
runCompilerScenariointo native (binary is the executable) vs non-native (node is the executable, needs tsc.js as first arg) paths, but the non-native path never addstsc.jsto args..addIf(!nativeBin && !usesPublicApi, tsc)for the benchmark command builder.addIf(!nativeBin, tsc)for the clean command builderFor comparison,
runStartupScenarioandrunTSServerScenarioalready correctly add their entry points (.add(entrypoint)and.add(path.join(__dirname, "measuretsserver.js"))respectively).