Skip to content

Signature help may not respect capabilities for NoActiveParameterSupport #1495

@DanielRosenwasser

Description

@DanielRosenwasser

Current code for signature help has the following:

var activeParameter *lsproto.UintegerOrNull
if argumentInfo.argumentIndex == nil {
	if clientOptions.SignatureInformation.NoActiveParameterSupport != nil && *clientOptions.SignatureInformation.NoActiveParameterSupport {
		activeParameter = nil
	}
} else {
	activeParameter = &lsproto.UintegerOrNull{Uinteger: ptrTo(uint32(*argumentInfo.argumentIndex))}
}

I think there's a bug because it needs to be set to 0 or something if NoActiveParameterSupport is not set or is set to true.

Should have a test that (un)sets that capability.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Domain: EditorRelated to the LSP server, editor experience

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions