Don’t look in JSExportAssignment and CommonJSExport for nodes #1886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the import resolver would incorrectly find nodes within synthetic/cloned functions created for JSExportAssignment and CommonJSExport nodes. These cloned nodes have JSDoc references but aren't valid keys in the JSDoc map, causing resolution failures.
- Prevents traversal into JSExportAssignment and CommonJSExport nodes when searching for nodes at a position
- Adds a regression test with nested JSDoc import types in a CommonJS export
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/ast/utilities.go |
Filters out JSExportAssignment and CommonJSExport nodes from position-based node search |
testdata/tests/cases/compiler/nestedJSDocImportType.ts |
Adds test case for nested JSDoc import type within CommonJS module export |
sandersn
approved these changes
Oct 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Member
|
I missed this while I was gone, but I find this special casing strange; why is it that such a generic algorithm needs an exception for these two nodes and not other JSDoc related stuff? Shouldn't we make the map have both keys or something rather than checking everywhere? |
GGomez99
pushed a commit
to GGomez99/typescript-go
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking for imports to resolve, we were hitting the cloned function inside the fake reparsed export, which says it has JSDoc attached, but isn’t actually the key into the JSDoc map because it’s the clone.