Unskip passing fourslash test #1922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR unskips a previously failing fourslash test (TestFindAllRefsForDefaultExport03) that is now passing. The test verifies "find all references" functionality for default exports in TypeScript.
- Removes the
t.Skip()call from the test - Removes the test from the failing tests list
- Adds the expected baseline output for the test
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/fourslash/tests/gen/findAllRefsForDefaultExport03_test.go |
Removed t.Skip() to enable the previously skipped test |
internal/fourslash/_scripts/failingTests.txt |
Removed TestFindAllRefsForDefaultExport03 from the failing tests list |
testdata/baselines/reference/fourslash/findAllReferences/findAllRefsForDefaultExport03.baseline.jsonc |
Added expected baseline output for the now-passing test |
andrewbranch
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why our typical infra is not catching this. Will look into that.