Create clickable links in quick info from @link JSDoc tags #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for creating clickable links in quick info tooltips from JSDoc @link tags. The main change converts plain text JSDoc link references into Markdown-formatted links that allow navigation to declarations within the codebase or to external URLs.
Key Changes
- Refactored JSDoc link handling to generate clickable Markdown links instead of plain text
- Added support for both code declarations (file://... links) and HTTP/HTTPS URLs in JSDoc links
- Converted several utility functions to methods on
LanguageServiceto enable access to position converters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/ls/hover.go | Core implementation of JSDoc link conversion to Markdown links with declaration resolution |
| internal/ls/completions.go | Updated to use refactored method for getting completion details with documentation |
| internal/ls/string_completions.go | Updated to use refactored method for string literal completion details |
jakebailey
reviewed
Oct 22, 2025
jakebailey
reviewed
Oct 23, 2025
jakebailey
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1895.