Skip to content

Use information from contextual type in hovers/quick info #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2025
Merged

Use information from contextual type in hovers/quick info #2073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e827c7
Use symbol of contextual type for object literal elements in hovers/q…
DanielRosenwasser Nov 13, 2025
8363567
Update passing tests.
DanielRosenwasser Nov 13, 2025
6cba17b
Use some `if var := ...; {}`s instead.
DanielRosenwasser Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions internal/fourslash/_scripts/failingTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,6 @@ TestQuickInfoForTypeParameterInTypeAlias1
TestQuickInfoForTypeParameterInTypeAlias2
TestQuickInfoForTypeofParameter
TestQuickInfoForUMDModuleAlias
TestQuickInfoFromContextualType
TestQuickInfoFunctionKeyword
TestQuickInfoGenerics
TestQuickInfoGetterSetter
Expand All @@ -471,7 +470,6 @@ TestQuickInfoJsDocNonDiscriminatedUnionSharedProp
TestQuickInfoJsdocTypedefMissingType
TestQuickInfoMappedSpreadTypes
TestQuickInfoMappedType
TestQuickInfoMappedTypeMethods
TestQuickInfoMappedTypeRecursiveInference
TestQuickInfoModuleVariables
TestQuickInfoNarrowedTypeOfAliasSymbol
Expand Down Expand Up @@ -526,7 +524,6 @@ TestQuickInfoTypeError
TestQuickInfoTypeOfThisInStatics
TestQuickInfoTypeOnlyNamespaceAndClass
TestQuickInfoUnionOfNamespaces
TestQuickInfoUnion_discriminated
TestQuickInfoWidenedTypes
TestQuickInfo_notInsideComment
TestQuickInforForSucessiveInferencesIsNotAny
Expand Down
2 changes: 1 addition & 1 deletion internal/fourslash/tests/gen/quickInfoFromContextualType_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

func TestQuickInfoFromContextualType(t *testing.T) {
t.Parallel()
t.Skip()

defer testutil.RecoverAndFail(t, "Panic on fourslash test")
const content = `// @Filename: quickInfoExportAssignmentOfGenericInterface_0.ts
interface I {
Expand Down
2 changes: 1 addition & 1 deletion internal/fourslash/tests/gen/quickInfoMappedTypeMethods_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

func TestQuickInfoMappedTypeMethods(t *testing.T) {
t.Parallel()
t.Skip()

defer testutil.RecoverAndFail(t, "Panic on fourslash test")
const content = `type M = { [K in 'one']: any };
const x: M = {
Expand Down
2 changes: 1 addition & 1 deletion internal/fourslash/tests/gen/quickInfoUnion_discriminated_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

func TestQuickInfoUnion_discriminated(t *testing.T) {
t.Parallel()
t.Skip()

defer testutil.RecoverAndFail(t, "Panic on fourslash test")
const content = `// @Filename: quickInfoJsDocTags.ts
type U = A | B;
Expand Down
14 changes: 13 additions & 1 deletion internal/ls/hover.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ func (l *LanguageService) ProvideHover(ctx context.Context, documentURI lsproto.
c, done := program.GetTypeCheckerForFile(ctx, file)
defer done()
rangeNode := getNodeForQuickInfo(node)
quickInfo, documentation := l.getQuickInfoAndDocumentationForSymbol(c, c.GetSymbolAtLocation(node), rangeNode, contentFormat)
symbol := getSymbolAtLocationForQuickInfo(c, node)
quickInfo, documentation := l.getQuickInfoAndDocumentationForSymbol(c, symbol, rangeNode, contentFormat)
if quickInfo == "" {
return lsproto.HoverOrNull{}, nil
}
Expand Down Expand Up @@ -282,6 +283,17 @@ func getNodeForQuickInfo(node *ast.Node) *ast.Node {
return node
}

func getSymbolAtLocationForQuickInfo(c *checker.Checker, node *ast.Node) *ast.Symbol {
if objectElement := getContainingObjectLiteralElement(node); objectElement != nil {
if contextualType := c.GetContextualType(objectElement.Parent, checker.ContextFlagsNone); contextualType != nil {
if properties := c.GetPropertySymbolsFromContextualType(objectElement, contextualType, false /*unionSymbolOk*/); len(properties) == 1 {
return properties[0]
}
}
}
return c.GetSymbolAtLocation(node)
}

func inConstructorContext(node *ast.Node) bool {
if node.Kind == ast.KindConstructorKeyword {
return true
Expand Down