Skip to content

Sort failingTests and manualTests in en-US #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

Sort failingTests and manualTests in en-US #2113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 61 additions & 61 deletions internal/fourslash/_scripts/failingTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ TestAutoImportModuleNone1
TestAutoImportNodeNextJSRequire
TestAutoImportPathsAliasesAndBarrels
TestAutoImportPnpm
TestAutoImportProvider4
TestAutoImportProvider_exportMap1
TestAutoImportProvider_exportMap2
TestAutoImportProvider_exportMap3
Expand All @@ -33,6 +32,7 @@ TestAutoImportProvider_pnpm
TestAutoImportProvider_wildcardExports1
TestAutoImportProvider_wildcardExports2
TestAutoImportProvider_wildcardExports3
TestAutoImportProvider4
TestAutoImportSortCaseSensitivity1
TestAutoImportSymlinkCaseSensitive
TestAutoImportTypeImport1
Expand Down Expand Up @@ -60,6 +60,16 @@ TestCompletionForComputedStringProperties
TestCompletionForMetaProperty
TestCompletionForObjectProperty
TestCompletionForStringLiteral
TestCompletionForStringLiteral_details
TestCompletionForStringLiteral_quotePreference
TestCompletionForStringLiteral_quotePreference1
TestCompletionForStringLiteral_quotePreference2
TestCompletionForStringLiteral_quotePreference3
TestCompletionForStringLiteral_quotePreference4
TestCompletionForStringLiteral_quotePreference5
TestCompletionForStringLiteral_quotePreference6
TestCompletionForStringLiteral_quotePreference7
TestCompletionForStringLiteral_quotePreference8
TestCompletionForStringLiteral4
TestCompletionForStringLiteralExport
TestCompletionForStringLiteralImport1
Expand All @@ -81,16 +91,6 @@ TestCompletionForStringLiteralRelativeImport4
TestCompletionForStringLiteralRelativeImport6
TestCompletionForStringLiteralRelativeImportAllowJSTrue
TestCompletionForStringLiteralWithDynamicImport
TestCompletionForStringLiteral_details
TestCompletionForStringLiteral_quotePreference
TestCompletionForStringLiteral_quotePreference1
TestCompletionForStringLiteral_quotePreference2
TestCompletionForStringLiteral_quotePreference3
TestCompletionForStringLiteral_quotePreference4
TestCompletionForStringLiteral_quotePreference5
TestCompletionForStringLiteral_quotePreference6
TestCompletionForStringLiteral_quotePreference7
TestCompletionForStringLiteral_quotePreference8
TestCompletionImportMeta
TestCompletionImportMetaWithGlobalDeclaration
TestCompletionImportModuleSpecifierEndingDts
Expand Down Expand Up @@ -128,16 +128,16 @@ TestCompletionListInUnclosedTaggedTemplate02
TestCompletionListInUnclosedTemplate01
TestCompletionListInUnclosedTemplate02
TestCompletionListInvalidMemberNames
TestCompletionListInvalidMemberNames2
TestCompletionListInvalidMemberNames_escapeQuote
TestCompletionListInvalidMemberNames_startWithSpace
TestCompletionListInvalidMemberNames_withExistingIdentifier
TestCompletionListInvalidMemberNames2
TestCompletionListOfGenericSymbol
TestCompletionListOnAliases
TestCompletionListsStringLiteralTypeAsIndexedAccessTypeObject
TestCompletionListStringParenthesizedExpression
TestCompletionListStringParenthesizedType
TestCompletionListWithoutVariableinitializer
TestCompletionListsStringLiteralTypeAsIndexedAccessTypeObject
TestCompletionNoAutoInsertQuestionDotForThis
TestCompletionNoAutoInsertQuestionDotForTypeParameter
TestCompletionNoAutoInsertQuestionDotWithUserPreferencesOff
Expand All @@ -149,7 +149,6 @@ TestCompletionOfAwaitPromise6
TestCompletionOfAwaitPromise7
TestCompletionOfInterfaceAndVar
TestCompletionPreferredSuggestions1
TestCompletionWithConditionalOperatorMissingColon
TestCompletionsAfterJSDoc
TestCompletionsBeforeRestArg1
TestCompletionsClassMemberImportTypeNodeParameter1
Expand All @@ -159,7 +158,6 @@ TestCompletionsClassMemberImportTypeNodeParameter4
TestCompletionsElementAccessNumeric
TestCompletionsExportImport
TestCompletionsGenericTypeWithMultipleBases1
TestCompletionsImportOrExportSpecifier
TestCompletionsImport_default_alreadyExistedWithRename
TestCompletionsImport_default_anonymous
TestCompletionsImport_details_withMisspelledName
Expand All @@ -176,13 +174,14 @@ TestCompletionsImport_named_didNotExistBefore
TestCompletionsImport_noSemicolons
TestCompletionsImport_packageJsonImportsPreference
TestCompletionsImport_quoteStyle
TestCompletionsImport_reExportDefault2
TestCompletionsImport_reExport_wrongName
TestCompletionsImport_reExportDefault2
TestCompletionsImport_require_addToExisting
TestCompletionsImport_typeOnly
TestCompletionsImport_umdDefaultNoCrash1
TestCompletionsImport_uriStyleNodeCoreModules2
TestCompletionsImport_windowsPathsProjectRelative
TestCompletionsImportOrExportSpecifier
TestCompletionsInExport
TestCompletionsInExport_moduleBlock
TestCompletionsInRequire
Expand All @@ -207,23 +206,24 @@ TestCompletionsOverridingMethod4
TestCompletionsOverridingMethod9
TestCompletionsOverridingMethodCrash1
TestCompletionsOverridingProperties1
TestCompletionsPathsJsonModule
TestCompletionsPathsRelativeJsonModule
TestCompletionsPaths_importType
TestCompletionsPaths_kinds
TestCompletionsPaths_pathMapping
TestCompletionsPaths_pathMapping_nonTrailingWildcard1
TestCompletionsPaths_pathMapping_parentDirectory
TestCompletionsPathsJsonModule
TestCompletionsPathsRelativeJsonModule
TestCompletionsRecommended_namespace
TestCompletionsRecommended_union
TestCompletionsRedeclareModuleAsGlobal
TestCompletionsStringsWithTriggerCharacter
TestCompletionsSymbolMembers
TestCompletionsTriggerCharacter
TestCompletionsTuple
TestCompletionsUniqueSymbol1
TestCompletionsUniqueSymbol_import
TestCompletionsUniqueSymbol1
TestCompletionsWithDeprecatedTag10
TestCompletionWithConditionalOperatorMissingColon
TestConstEnumQuickInfoAndCompletionList
TestConstQuickInfoAndCompletionList
TestContextuallyTypedFunctionExpressionGeneric1
Expand All @@ -233,8 +233,8 @@ TestExportDefaultClass
TestExportDefaultFunction
TestFindReferencesBindingPatternInJsdocNoCrash1
TestFindReferencesBindingPatternInJsdocNoCrash2
TestGenericCombinatorWithConstraints1
TestGenericCombinators3
TestGenericCombinatorWithConstraints1
TestGenericFunctionWithGenericParams1
TestGenericInterfacesWithConstraints1
TestGenericTypeWithMultipleBases1MultiFile
Expand All @@ -258,25 +258,43 @@ TestGetJavaScriptQuickInfo8
TestGetJavaScriptSyntacticDiagnostics24
TestGetOccurrencesIfElseBroken
TestHoverOverComment
TestImportCompletions_importsMap1
TestImportCompletions_importsMap2
TestImportCompletions_importsMap3
TestImportCompletions_importsMap4
TestImportCompletions_importsMap5
TestImportCompletionsPackageJsonExportsSpecifierEndsInTs
TestImportCompletionsPackageJsonExportsTrailingSlash1
TestImportCompletionsPackageJsonImports_ts
TestImportCompletionsPackageJsonImportsConditions1
TestImportCompletionsPackageJsonImportsLength1
TestImportCompletionsPackageJsonImportsLength2
TestImportCompletionsPackageJsonImportsPattern
TestImportCompletionsPackageJsonImportsPattern2
TestImportCompletionsPackageJsonImportsPattern_capsInPath1
TestImportCompletionsPackageJsonImportsPattern_capsInPath2
TestImportCompletionsPackageJsonImportsPattern_js_ts
TestImportCompletionsPackageJsonImportsPattern_ts
TestImportCompletionsPackageJsonImportsPattern_ts_ts
TestImportCompletionsPackageJsonImports_ts
TestImportCompletions_importsMap1
TestImportCompletions_importsMap2
TestImportCompletions_importsMap3
TestImportCompletions_importsMap4
TestImportCompletions_importsMap5
TestImportCompletionsPackageJsonImportsPattern2
TestImportFixesGlobalTypingsCache
TestImportNameCodeFix_avoidRelativeNodeModules
TestImportNameCodeFix_fileWithNoTrailingNewline
TestImportNameCodeFix_HeaderComment1
TestImportNameCodeFix_HeaderComment2
TestImportNameCodeFix_importType1
TestImportNameCodeFix_importType2
TestImportNameCodeFix_importType4
TestImportNameCodeFix_importType7
TestImportNameCodeFix_importType8
TestImportNameCodeFix_jsx1
TestImportNameCodeFix_order
TestImportNameCodeFix_order2
TestImportNameCodeFix_pnpm1
TestImportNameCodeFix_preferBaseUrl
TestImportNameCodeFix_reExportDefault
TestImportNameCodeFix_symlink
TestImportNameCodeFix_trailingComma
TestImportNameCodeFix_withJson
TestImportNameCodeFixConvertTypeOnly1
TestImportNameCodeFixExistingImport10
TestImportNameCodeFixExistingImport11
Expand All @@ -297,24 +315,6 @@ TestImportNameCodeFixNewImportFileQuoteStyleMixed0
TestImportNameCodeFixNewImportFileQuoteStyleMixed1
TestImportNameCodeFixNewImportRootDirs0
TestImportNameCodeFixNewImportTypeRoots1
TestImportNameCodeFix_HeaderComment1
TestImportNameCodeFix_HeaderComment2
TestImportNameCodeFix_avoidRelativeNodeModules
TestImportNameCodeFix_fileWithNoTrailingNewline
TestImportNameCodeFix_importType1
TestImportNameCodeFix_importType2
TestImportNameCodeFix_importType4
TestImportNameCodeFix_importType7
TestImportNameCodeFix_importType8
TestImportNameCodeFix_jsx1
TestImportNameCodeFix_order
TestImportNameCodeFix_order2
TestImportNameCodeFix_pnpm1
TestImportNameCodeFix_preferBaseUrl
TestImportNameCodeFix_reExportDefault
TestImportNameCodeFix_symlink
TestImportNameCodeFix_trailingComma
TestImportNameCodeFix_withJson
TestImportTypeCompletions1
TestImportTypeCompletions3
TestImportTypeCompletions4
Expand All @@ -329,6 +329,7 @@ TestJavascriptModules20
TestJavascriptModulesTypeImport
TestJsDocAugments
TestJsDocAugmentsAndExtends
TestJsdocCallbackTag
TestJsDocExtends
TestJsDocFunctionSignatures10
TestJsDocFunctionSignatures11
Expand All @@ -338,6 +339,9 @@ TestJsDocFunctionSignatures7
TestJsDocFunctionSignatures8
TestJsDocGenerics2
TestJsDocInheritDoc
TestJsdocLink2
TestJsdocLink3
TestJsdocLink6
TestJsDocPropertyDescription1
TestJsDocPropertyDescription10
TestJsDocPropertyDescription11
Expand All @@ -352,19 +356,15 @@ TestJsDocPropertyDescription8
TestJsDocPropertyDescription9
TestJsDocServices
TestJsDocTagsWithHyphen
TestJsFileImportNoTypes2
TestJsQuickInfoGenerallyAcceptableSize
TestJsRequireQuickInfo
TestJsdocCallbackTag
TestJsdocLink2
TestJsdocLink3
TestJsdocLink6
TestJsdocTemplatePrototypeCompletions
TestJsdocThrowsTagCompletion
TestJsdocTypedefTag
TestJsdocTypedefTag2
TestJsdocTypedefTagNamespace
TestJsdocTypedefTagServices
TestJsFileImportNoTypes2
TestJsQuickInfoGenerallyAcceptableSize
TestJsRequireQuickInfo
TestLetQuickInfoAndCompletionList
TestLocalFunction
TestMemberListInReopenedEnum
Expand All @@ -374,9 +374,9 @@ TestMemberListOnContextualThis
TestModuleNodeNextAutoImport2
TestModuleNodeNextAutoImport3
TestNgProxy1
TestNodeModulesImportCompletions1
TestNoQuickInfoForLabel
TestNoQuickInfoInWhitespace
TestNodeModulesImportCompletions1
TestNumericPropertyNames
TestOverloadQuickInfo
TestParameterWithDestructuring
Expand Down Expand Up @@ -430,12 +430,14 @@ TestPathCompletionsTypesVersionsWildcard4
TestPathCompletionsTypesVersionsWildcard5
TestPathCompletionsTypesVersionsWildcard6
TestProtoVarVisibleWithOuterScopeUnderscoreProto
TestQuickInfo_notInsideComment
TestQuickinfo01
TestQuickInfoAlias
TestQuickInfoAssertionNodeNotReusedWhenTypeNotEquivalent1
TestQuickInfoBindingPatternInJsdocNoCrash1
TestQuickInfoClassKeyword
TestQuickInfoContextualTyping
TestQuickInfoContextuallyTypedSignatureOptionalParameterFromIntersection1
TestQuickInfoContextualTyping
TestQuickInfoDisplayPartsIife
TestQuickInfoElementAccessDeclaration
TestQuickInfoForConstTypeReference
Expand All @@ -448,13 +450,15 @@ TestQuickInfoForGenericTaggedTemplateExpression
TestQuickInfoForGetterAndSetter
TestQuickInfoForIndexerResultWithConstraint
TestQuickInfoForNamedTupleMember
TestQuickinfoForNamespaceMergeWithClassConstrainedToSelf
TestQuickInfoForObjectBindingElementPropertyName04
TestQuickInfoForShorthandProperty
TestQuickInfoForSyntaxErrorNoError
TestQuickInfoForTypeofParameter
TestQuickInfoForTypeParameterInTypeAlias1
TestQuickInfoForTypeParameterInTypeAlias2
TestQuickInfoForTypeofParameter
TestQuickInfoForUMDModuleAlias
TestQuickinfoForUnionProperty
TestQuickInfoFunctionKeyword
TestQuickInfoGenerics
TestQuickInfoGetterSetter
Expand All @@ -465,10 +469,10 @@ TestQuickInfoInWithBlock
TestQuickInfoJSDocBackticks
TestQuickInfoJSDocFunctionNew
TestQuickInfoJSDocFunctionThis
TestQuickInfoJSExport
TestQuickInfoJsDocGetterSetterNoCrash1
TestQuickInfoJsDocNonDiscriminatedUnionSharedProp
TestQuickInfoJsdocTypedefMissingType
TestQuickInfoJSExport
TestQuickInfoMappedSpreadTypes
TestQuickInfoMappedType
TestQuickInfoMappedTypeRecursiveInference
Expand Down Expand Up @@ -512,6 +516,7 @@ TestQuickInfoOnUndefined
TestQuickInfoOnVarInArrowExpression
TestQuickInfoPrivateIdentifierInTypeReferenceNoCrash1
TestQuickInfoPropertyTag
TestQuickInforForSucessiveInferencesIsNotAny
TestQuickInfoSignatureOptionalParameterFromUnion1
TestQuickInfoSignatureRestParameterFromUnion1
TestQuickInfoSignatureRestParameterFromUnion2
Expand All @@ -526,11 +531,6 @@ TestQuickInfoTypeOfThisInStatics
TestQuickInfoTypeOnlyNamespaceAndClass
TestQuickInfoUnionOfNamespaces
TestQuickInfoWidenedTypes
TestQuickInfo_notInsideComment
TestQuickInforForSucessiveInferencesIsNotAny
TestQuickinfo01
TestQuickinfoForNamespaceMergeWithClassConstrainedToSelf
TestQuickinfoForUnionProperty
TestQuickinfoWrongComment
TestRecursiveInternalModuleImport
TestReferencesInEmptyFile
Expand Down
2 changes: 1 addition & 1 deletion internal/fourslash/_scripts/makeManual.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function main() {

if (!manualTests.includes(testName)) {
manualTests.push(testName);
manualTests.sort();
manualTests.sort((a, b) => a.localeCompare(b, "en-US"));
fs.writeFileSync(manualTestsPath, [...manualTests, ""].join("\n"), "utf-8");
}
}
Expand Down
2 changes: 1 addition & 1 deletion internal/fourslash/_scripts/updateFailing.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function main() {
failingTests.push(match[1]);
}

fs.writeFileSync(failingTestsPath, failingTests.sort().join("\n") + "\n", "utf-8");
fs.writeFileSync(failingTestsPath, failingTests.sort((a, b) => a.localeCompare(b, "en-US")).join("\n") + "\n", "utf-8");
convertFourslash();
}

Expand Down