Add stringer-alike String methods to non-string LSP enums #2148
+526
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds String() methods to non-string LSP enumerations in the generated protocol code, making them compatible with Go's Stringer interface. The implementation uses a stringer-style approach with string concatenation and index arrays for memory efficiency.
Key changes:
- Generator now creates
String()methods for all non-string enums - Bitflag enums (currently only
WatchKind) get special handling to display combined flags as "Flag1|Flag2" - Regular enums use an index-based lookup for efficient string conversion
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/lsp/lsproto/_generate/generate.mts | Added logic to generate String() methods for non-string enums, with separate handling for bitflag vs. regular enums |
| internal/lsp/lsproto/lsp_generated.go | Generated String() methods for 24 different enum types using the stringer-style pattern |
sheetalkamat
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.