Make fourslash a real async client #2184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the fourslash runner into an actual async LSP client, removing the hacks we have to make the init cycle work. There are now goroutines similar to what we do inside the LSP server itself, which manage the calls back and forth, fetching info, etc.
This involved restructuring things a bit, along with fixes to ensure that we never attempt to use
ton the wrong goroutine, as well as eliminatingt.Cleanup, which mistakenly closed overtto run stuff, which shouldn't really work.This leads to a large diff due to the fourslash tests updating, but it's sort of unavoidable.
This also lets us disable the push diag hack in fourslash tests. We ignore the notification (and, don't really have a way to wait for them), but that's okay for now.