Fix JSX name in folding ranges #2199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
requested review from
andrewbranch,
Copilot,
gabritto and
navya9singh
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in JSX folding ranges where JSX elements with property access names (e.g., <Components.Nested>) were not handled correctly. The fix changes from calling .Text() on the tag name node to using scanner.GetTextOfNode(), which properly extracts the full text from the source file.
Key Changes
- Fixed JSX tag name extraction in folding ranges to support property access expressions
- Added test coverage for JSX property access in folding ranges
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/ls/folding.go | Changed JSX tag name extraction from .Text() method to scanner.GetTextOfNode() to properly handle property access expressions like <Components.Nested> |
| internal/fourslash/tests/foldingRangeJSXPropertyAccess_test.go | Added new test case to verify folding ranges work correctly with JSX property access syntax |
andrewbranch
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2198
This is something I inadvertently broke in the PR.