Move checker to checker package #227
Conversation
jakebailey
requested review from
ahejlsberg,
andrewbranch,
gabritto,
rbuckton and
sandersn
| GetResolvedModule(currentSourceFile *ast.SourceFile, moduleReference string) *ast.SourceFile | ||
| } | ||
|
|
||
| type Host interface{} |
There was a problem hiding this comment.
This is empty because it's unused; will fixish.
|
I'll probably need to refactor #229 if this merges first. |
|
I'm going to wait for Anders to okay this since he probably has something in flight. |
|
Quick question: Are we following up with PRs to also create |
|
The latter is already in https://github.com/microsoft/typescript-go/tree/main/internal/printer; the emit code in the compiler package is just the stuff that does the looping, more or less. We could move Program, though that would leave the compiler package empty. Maybe no compiler package is good? |
|
Yeah, after this PR, the |
|
#232 shows what the rest of that movement would look like. |
ahejlsberg
left a comment
ahejlsberg
left a comment
There was a problem hiding this comment.
Approved once #233 gets merged.
|
Merge with main worked, since git does understand this is a code move, very nice. |
This moves all of the checker code into its own package, mainly to speed up Program compile time.