Reenable fail-fast in merge queues #2274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR conditionally enables fail-fast behavior in CI workflows specifically for merge queue runs. The rationale is that failures in merge queues are typically either platform flakes or runtime merge conflicts, so there's no value in continuing to run all jobs when one fails.
Key Changes
- Modified
fail-fastsetting in thetestjob to betrueonly whengithub.event_name == 'merge_group' - Applied the same conditional logic to the
lintjob for consistency
sheetalkamat
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a job fails in a merge queue, it's either a platform flake, or a runtime merge conflict. Don't bother running all jobs and let it quit out as early as possible.