Support FORCE_COLOR #2596
Merged
Support FORCE_COLOR #2596
+326
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Implements support for the FORCE_COLOR environment variable in the tsc CLI so that colored output can be forced even when stdout is not a TTY, while still honoring NO_COLOR to disable colors.
Changes:
- Updated
defaultIsPrettyto considerNO_COLORandFORCE_COLORbefore falling back to TTY detection. - Extended
TestTscCommandlinewith scenarios that coverFORCE_COLORalone andNO_COLORplusFORCE_COLOR. - Added new command-line baselines to validate colored vs non-colored help output under these environment configurations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/execute/tsc/diagnostics.go |
Adjusts defaultIsPretty so NO_COLOR disables colors, FORCE_COLOR forces colors regardless of TTY, and TTY is used only as a fallback. |
internal/execute/tsctests/tsc_test.go |
Adds two new command-line test scenarios exercising FORCE_COLOR and the precedence of NO_COLOR over FORCE_COLOR. |
testdata/baselines/reference/tsc/commandLine/adds-color-when-FORCE_COLOR-is-set.js |
Baseline showing ANSI-colored help output when FORCE_COLOR is set. |
testdata/baselines/reference/tsc/commandLine/does-not-add-color-when-NO_COLOR-is-set-even-if-FORCE_COLOR-is-set.js |
Baseline confirming uncolored help output when NO_COLOR is set, even if FORCE_COLOR is also set. |
sheetalkamat
approved these changes
Jan 27, 2026
| if sys.GetEnvironmentVariable("NO_COLOR") != "" { | ||
| return false | ||
| } | ||
| if sys.GetEnvironmentVariable("FORCE_COLOR") != "" { |
Member
There was a problem hiding this comment.
It's weird that we just look for any content (e.g. someone could write FALSE), but I don't know how other tools deal with this.
Member
Author
There was a problem hiding this comment.
They do what this does, more or less.
- https://github.com/alexeyraspopov/picocolors/blob/0e7c4af2de299dd7bc5916f2bddd151fa2f66740/picocolors.js#L3-L4 (truthy check)
- https://github.com/nodejs/node/blob/150d154bf1ba6cc28ca6276b94117b5a2813e6c8/lib/internal/tty.js#L126 (leveled, but truthy means a nonzero level)
- https://github.com/chalk/chalk/blob/aa06bb5ac3f14df9fda8cfb54274dfc165ddfdef/source/vendor/supports-color/index.js#L35 (same as node)
DanielRosenwasser
approved these changes
Jan 28, 2026
Member
DanielRosenwasser
left a comment
DanielRosenwasser
left a comment
There was a problem hiding this comment.
If all tools deal with non-empty strings in this way, seems good.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2540
picocolors, chalk, Node, etc, all support this.
Strada doesn't, but it seems to matter for people trying to use
tsgo, so, I think it's worth doing. And probably sticking in Strada if we want.