Preserve error elaboration for indexed access type assignments#3220
Open
WhiteMinds wants to merge 1 commit intomicrosoft:mainfrom
Open
Preserve error elaboration for indexed access type assignments#3220WhiteMinds wants to merge 1 commit intomicrosoft:mainfrom
WhiteMinds wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When assigning to an indexed access type like this["faa"], the checker resolves the constraint and performs a structural comparison that generates specific error messages (e.g., missing properties or type mismatches). However, reportRelationError unconditionally clears errorChain before reporting the generic "could be instantiated with an arbitrary type" message, discarding the useful elaboration. This change preserves errorChain when the target is an IndexedAccess type, so users see both the generic message and the specific details about what went wrong (e.g., "Property 'key' is missing" or "Types of property 'key' are incompatible"). Fixes microsoft/TypeScript#63206
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/TypeScript#63206
Problem
When assigning to an indexed access type (e.g.
this["faa"]),reportRelationErrorunconditionally clearserrorChainbefore reporting the generic "could be instantiated with an arbitrary type" message, discarding the specific elaboration already computed from the constraint comparison (missing properties, type mismatches, etc.).Fix
Preserve
errorChainwhen the target is anIndexedAccesstype, so users see both the generic message and the specific details.Before
After
Two existing baselines updated to reflect the additional elaboration (no errors removed, only more specific detail added).