Accept baseline differences#3239
Conversation
ahejlsberg
requested review from
DanielRosenwasser,
RyanCavanaugh,
Copilot and
jakebailey
There was a problem hiding this comment.
Pull request overview
This PR records a first batch of accepted baseline differences between the TypeScript submodule baselines and this repo’s expected outputs, by adding the corresponding submoduleAccepted baseline diff artifacts and listing them in the acceptance manifest.
Changes:
- Extend
testdata/submoduleAccepted.txtwith new categorized entries for accepted submodule baseline diffs. - Add new baseline diff files under
testdata/baselines/reference/submoduleAccepted/compiler/covering types/symbols/errors/emit deltas for various compiler test cases.
Reviewed changes
Copilot reviewed 1 out of 89 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
testdata/submoduleAccepted.txt |
Adds new grouped manifest entries for accepted baseline diffs (deprecated features, type/symbol accuracy, errors, emit, etc.). |
testdata/baselines/reference/submoduleAccepted/compiler/*.diff |
Adds the accepted “old vs new” baseline diff artifacts referenced by the manifest. |
| compiler/assignmentToInstantiationExpression.js.diff | ||
| compiler/asyncArrowInClassES5(target=es2015).js.diff | ||
| compiler/augmentedTypesVar.js.diff | ||
| compiler/commentsFunction(target=es2015).js.diff |
There was a problem hiding this comment.
I don't think this one is a desirable diff.
There was a problem hiding this comment.
Ok, I'll remove this one.
| compiler/arrayIterationLibES5TargetDifferent(nolib=true,target=es2015).errors.txt.diff | ||
| compiler/arrayIterationLibES5TargetDifferent(nolib=true,target=esnext).errors.txt.diff | ||
|
|
||
| ## emit differences ## |
There was a problem hiding this comment.
Should we explain more why these are ignored? in general? The existing headers were terse but only because there wasn't much to say.
There was a problem hiding this comment.
We could call it "emit differences of no consequence". At least, that was the intent.
First batch of accepted baseline differences.