Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an intermittent type-checking error involving optional destructuring parameters by tightening when the checker reuses cached resolvedType values for binding element parents (avoiding reuse when the cached type may have included optionality).
Changes:
- Adjust
getTypeForBindingElementParentto avoid reusingvalueSymbolLinks.resolvedTypefor optional declarations understrictNullChecks. - Add a compiler repro test covering the previously intermittent phantom error scenario.
- Add/update reference
.typesand.symbolsbaselines for the new test.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/checker/checker.go |
Prevents reuse of cached parent types for binding patterns when optionality could be baked into the cached type, fixing the phantom error. |
testdata/tests/cases/compiler/bindingPatternOptionalParameterCached.ts |
Adds a minimal repro that should typecheck without errors (regression test for #3276). |
testdata/baselines/reference/compiler/bindingPatternOptionalParameterCached.types |
Records expected type baseline output for the new test. |
testdata/baselines/reference/compiler/bindingPatternOptionalParameterCached.symbols |
Records expected symbol baseline output for the new test. |
jakebailey
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes an incorrect reuse of cached types for binding element parents as suggested here.
Fixes #3276.