Fix organize imports crash with traceResolution#3289
Merged
gabritto merged 4 commits intomicrosoft:mainfrom Apr 15, 2026
Merged
Fix organize imports crash with traceResolution#3289gabritto merged 4 commits intomicrosoft:mainfrom
gabritto merged 4 commits intomicrosoft:mainfrom
Conversation
jakebailey
reviewed
Mar 29, 2026
gabritto
requested changes
Mar 30, 2026
| // Trace implements compiler.CompilerHost. | ||
| func (c *compilerHost) Trace(msg *diagnostics.Message, args ...any) { | ||
| panic("unimplemented") | ||
| if logger := c.logger.Verbose(); logger != nil { |
Member
There was a problem hiding this comment.
I'm not sure we need to check Verbose() here, since we're only going to call this with args if traceResolution is set anyway. Though maybe we need to check for len(args) to avoid printing a log message with empty content.
Contributor
Author
There was a problem hiding this comment.
I dropped the verbosity check now. I don't think it's worth checking the args anyhow. The msg itself doesn't have to support any args - and if this ends up pringint an empty log message then I think the bug would be elsewhere anyway
gabritto
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes a crash found here #3281 (comment)