Exposing more endpoints by navya9singh · Pull Request #3403 · microsoft/typescript-go

navya9singh · 2026-04-15T01:36:38Z

No description provided.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR expands the public API surface by exposing additional checker endpoints (types/signatures utilities) through the Go session layer and the TypeScript client libraries.

Changes:

Added new API methods/endpoints: resolved signature, non-nullable type, type-from-type-node, widened type, parameter type, array-like checks, and signature declaration printing.
Exposed NodeBuilderFlags in the TypeScript API to support node/signature printing flags.
Added Go checker wrappers for newly exposed functionality.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
internal/checker/printer.go	Exposes `SignatureToSignatureDeclaration` via `Checker`.
internal/checker/exports.go	Exposes widened-type functionality via `Checker`.
internal/api/session.go	Routes and implements new API handlers for the added endpoints.
internal/api/proto.go	Adds method constants, unmarshalers, and request parameter types for new endpoints.
_packages/api/src/sync/api.ts	Adds sync client methods for new endpoints and exports `NodeBuilderFlags`.
_packages/api/src/async/api.ts	Adds async client methods for new endpoints and exports `NodeBuilderFlags`.
_packages/api/src/enums/nodeBuilderFlags.ts	Adds generated runtime `NodeBuilderFlags` enum values.
_packages/api/src/enums/nodeBuilderFlags.enum.ts	Adds generated TypeScript `NodeBuilderFlags` type enum.

Copilot · 2026-04-15T01:43:10Z

+// handleGetParameterType returns the type of a parameter at a given index in a signature.
+func (s *Session) handleGetParameterType(ctx context.Context, params *GetParameterTypeParams) (*TypeResponse, error) {
+	setup, err := s.setupChecker(ctx, params.Snapshot, params.Project)
+	if err != nil {
+		return nil, err
+	}
+	defer setup.done()
+
+	sig, err := setup.sd.resolveSignatureHandle(params.Signature)
+	if err != nil {
+		return nil, err
+	}
+
+	t := setup.checker.GetTypeParameterAtPosition(sig, int(params.Index))
+	if t == nil {
+		return nil, nil
+	}
+
+	return setup.sd.registerType(t), nil
+}


This handler is documented and named to return a parameter type, but it calls GetTypeParameterAtPosition, which typically refers to a generic type parameter (e.g., T) rather than a function parameter’s type. Either switch to the checker API that returns the parameter type at position (commonly GetTypeAtPosition(signature, index)), or rename the endpoint/params/method to getTypeParameterAtPosition to match the implemented behavior.

Name is same as that in Strada. The function returns the type of parameter as an index and not a generic type parameter.

No, Copilot is right about this. The function you wrote here returns the type of a generic type parameter. The checker function you need to use is called getTypeAtPosition and isn't exported yet.

Copilot · 2026-04-15T01:43:11Z

+	sig, err := setup.sd.resolveSignatureHandle(params.Signature)
+	if err != nil {
+		return nil, err
+	}


params.Index is int32 and is directly cast to int without validation. Negative values (or out-of-range values) should be rejected with a clear error to avoid undefined behavior or downstream panics inside the checker. Consider validating params.Index >= 0 (and, if feasible, bounds-checking against the signature’s parameter count) and returning an error like invalid parameter index.

Suggested change

}

}

if params.Index < 0 {

return nil, fmt.Errorf("invalid parameter index")

}

Copilot · 2026-04-15T01:43:11Z

+    signatureToSignatureDeclaration(signature: Signature, kind: number, enclosingDeclaration?: Node, flags?: number): Node | undefined {
+        const binaryData = this.client.apiRequestBinary("signatureToSignatureDeclaration", {
+            snapshot: this.snapshotId,
+            project: this.projectId,
+            signature: signature.id,
+            kind,
+            location: enclosingDeclaration ? getNodeId(enclosingDeclaration) : undefined,
+            flags,
+        });


The TS client method is typed with kind: number and flags?: number, but this endpoint is semantically tied to specific enums (AST Kind/SyntaxKind for kind, and NodeBuilderFlags for flags). Since NodeBuilderFlags is already added to exports, update the method signature to use flags?: NodeBuilderFlags (and a stronger type for kind if available) to prevent accidental invalid values and improve IntelliSense.

Copilot · 2026-04-15T01:43:12Z

+    async signatureToSignatureDeclaration(signature: Signature, kind: number, enclosingDeclaration?: Node, flags?: number): Promise<Node | undefined> {
+        const binaryData = await this.client.apiRequestBinary("signatureToSignatureDeclaration", {
+            snapshot: this.snapshotId,
+            project: this.projectId,
+            signature: signature.id,
+            kind,
+            location: enclosingDeclaration ? getNodeId(enclosingDeclaration) : undefined,
+            flags,
+        });


Same typing issue as the sync client: kind/flags are exposed as plain numbers. Prefer flags?: NodeBuilderFlags (and a stronger enum type for kind if available) so callers don’t accidentally pass unrelated constants.

Copilot · 2026-04-15T01:43:12Z

+// GetNonNullableTypeParams returns the type with null and undefined removed.
+type GetNonNullableTypeParams struct {
+	Snapshot Handle[project.Snapshot] `json:"snapshot"`
+	Project  Handle[project.Project]  `json:"project"`
+	Type     Handle[checker.Type]     `json:"type"`
+}
+
+// GetTypeFromTypeNodeParams returns the type for a type node.
+type GetTypeFromTypeNodeParams struct {
+	Snapshot Handle[project.Snapshot] `json:"snapshot"`
+	Project  Handle[project.Project]  `json:"project"`
+	Location Handle[ast.Node]         `json:"location"`
+}
+
+// GetWidenedTypeParams returns the widened type of a type.


These doc comments describe the result of the operation rather than what the params struct represents (e.g., “returns …”). For clarity and consistency, reword to something like: // GetNonNullableTypeParams are the parameters for the getNonNullableType method. (Similarly for GetTypeFromTypeNodeParams, GetWidenedTypeParams, and GetParameterTypeParams.)

Suggested change

// GetNonNullableTypeParams returns the type with null and undefined removed.

type GetNonNullableTypeParams struct {

Snapshot Handle[project.Snapshot] `json:"snapshot"`

Project Handle[project.Project] `json:"project"`

Type Handle[checker.Type] `json:"type"`

}

// GetTypeFromTypeNodeParams returns the type for a type node.

type GetTypeFromTypeNodeParams struct {

Snapshot Handle[project.Snapshot] `json:"snapshot"`

Project Handle[project.Project] `json:"project"`

Location Handle[ast.Node] `json:"location"`

}

// GetWidenedTypeParams returns the widened type of a type.

// GetNonNullableTypeParams are the parameters for the getNonNullableType method.

type GetNonNullableTypeParams struct {

Snapshot Handle[project.Snapshot] `json:"snapshot"`

Project Handle[project.Project] `json:"project"`

Type Handle[checker.Type] `json:"type"`

}

// GetTypeFromTypeNodeParams are the parameters for the getTypeFromTypeNode method.

type GetTypeFromTypeNodeParams struct {

Snapshot Handle[project.Snapshot] `json:"snapshot"`

Project Handle[project.Project] `json:"project"`

Location Handle[ast.Node] `json:"location"`

}

// GetWidenedTypeParams are the parameters for the getWidenedType method.

…o navyasingh/updatingExport

…o dev/navyasingh/moreEndpoints

andrewbranch · 2026-04-28T23:57:37Z

@@ -0,0 +1,36 @@
+// Code generated by Herebyfile.mjs generate:enums from internal/nodebuilder/types.go. DO NOT EDIT.


I don't see a change to Herebyfile; where did this enum come from?

Updated that and re-generated

andrewbranch · 2026-04-29T00:04:08Z

+}
+
+// NodeReferenceInfo is a compact representation of a node-backed reference entry suitable for sending over the wire.
+type NodeReferenceInfo struct {


This type seems incredibly specialized to a single use case despite a very generic name. I think this should just be replaced by Handle[ast.Node].

I'll address all find-all-references api comments in a separate PR

andrewbranch

All the find-all-reference related APIs need to be significantly reworked in order to be useful outside of your specific use case.

andrewbranch · 2026-04-29T00:07:07Z

 }
+
+// handleProbablyUsesSemicolons checks whether a source file probably uses semicolons.
+func (s *Session) handleProbablyUsesSemicolons(ctx context.Context, params *GetSourceFileParams) (bool, error) {


This seems like something that doesn't need to be answered over the wire.

andrewbranch · 2026-04-29T00:14:02Z

+
+// handleSomeSignatureUsage checks if any usage of a signature has more arguments than the given parameter index,
+// or if any reference is a non-call usage. Ports Strada's FindAllReferences.Core.someSignatureUsage.
+func (s *Session) handleSomeSignatureUsage(ctx context.Context, params *SomeSignatureUsageParams) (bool, error) {


This name doesn't make sense. The Strada function was so named because it took a predicate function that was called for each signature and returned a boolean the first time the predicate returns true, like Array.prototype.some. You can't pass a predicate function over the wire, so I assume you've baked in the particular predicate function you needed, but consequently the method is a misnomer and the implementation is so specific that no other API consumer could use it. Instead, you should just be using the API to get all the signature usages and then doing whatever analysis on the client side.

andrewbranch · 2026-04-29T00:20:50Z

+}
+
+// handleEachSymbolReferenceInFile returns positions of all references to a symbol in a file.
+func (s *Session) handleEachSymbolReferenceInFile(ctx context.Context, params *IsSymbolReferencedInFileParams) ([]int, error) {


Similar issue; the name is no longer appropriate for the implementation because the Strada code took a callback so the name was evoking Array.prototype.forEach. This should be GetSymbolReferencesInFile and return a list of node handles to identifiers.

andrewbranch · 2026-04-29T00:22:23Z

+	}
+
+	// Get the source file from the node handle
+	_, _, _, path, err := parseNodeHandle(params.Definition)


It looks like this decoding is duplicated with node, err := s.resolveNodeHandle(setup.program, params.Definition) above

andrewbranch · 2026-04-29T00:26:50Z

+func (s *Session) setupLanguageService(setup checkerSetup, projectHandle Handle[project.Project], activeFile string) (*ls.LanguageService, error) {
+	projectName := parseProjectHandle(projectHandle)
+	proj := setup.sd.snapshot.ProjectCollection.GetProjectByPath(projectName)


This shouldn't take a checkerSetup because it has to duplicate getting the project and program.

andrewbranch · 2026-04-29T00:38:26Z

+type IsSymbolReferencedInFileParams struct {
+	Snapshot   Handle[project.Snapshot] `json:"snapshot"`
+	Project    Handle[project.Project]  `json:"project"`
+	Definition Handle[ast.Node]         `json:"definition"`


I don't think "definition" makes sense as a parameter to answer the question "is a symbol referenced in a file"—I would expect it to take a symbol and a file. It looks like Strada wants a "definition" identifier because the comment says "Used as a quick check for whether a symbol is used at all in a file (besides its definition)." But the Strada API also doesn't take a symbol as an input; it just takes the identifier. So the original name is bad, but the contract is basically "give me the identifier of a declaration and I'll tell you if it's used anywhere else in the same file," which is fairly coherent. That said, it just uses eachSymbolReferenceInFile which I've suggested use expose as GetSymbolReferencesInFile, so I'm not sure it's worth it to expose this separate method.

andrewbranch · 2026-04-29T00:42:33Z

+}
+
+// handleGetReferencedSymbolsForNode finds all references to a node and returns compact NodeReferenceInfo entries.
+func (s *Session) handleGetReferencedSymbolsForNode(ctx context.Context, params *GetReferencedSymbolsForNodeParams) ([]NodeReferenceInfo, error) {


I already suggested you delete the NodeReferenceInfo type, but now I'm seeing that it's only used on a method called GetReferencedSymbolsForNode, but the return type isn't even anything close to a symbol. I'm totally confused by this.

This reverts commit 66c5058.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Copilot · 2026-04-29T19:08:22Z

+	}
+
+	if params.Index < 0 {
+		return nil, fmt.Errorf("%w: invalid parameter index", ErrClientError)


The client error omits the offending index value, which makes debugging harder. Include params.Index in the message (and keep it classified as ErrClientError), e.g. invalid parameter index: <value>.

Suggested change

return nil, fmt.Errorf("%w: invalid parameter index", ErrClientError)

return nil, fmt.Errorf("%w: invalid parameter index: %d", ErrClientError, params.Index)

Copilot · 2026-04-29T19:08:22Z

 	return candidates
 }

+// GetTypeAtPosition returns the type of a parameter at a given index in a signature.


The exported method name GetTypeAtPosition is easily confused with the existing location-based getTypeAtPosition/getTypeAtLocation API surface. Either (a) rename this exported wrapper to something signature-specific (e.g., GetSignatureParameterTypeAtPosition), or (b) at least adjust the doc comment to precisely match the underlying semantics (parameter vs. other signature positions) to reduce ambiguity for API consumers.

Suggested change

// GetTypeAtPosition returns the type of a parameter at a given index in a signature.

// GetTypeAtPosition returns the type at the given position within a signature.

// The pos argument is a signature position (for example, a parameter index), not

// a source-code position or AST location.

Copilot · 2026-04-29T19:08:23Z

+export var NodeBuilderFlags: any;
+(function (NodeBuilderFlags) {
+    NodeBuilderFlags[NodeBuilderFlags["None"] = 0] = "None";
+    NodeBuilderFlags[NodeBuilderFlags["NoTruncation"] = 1] = "NoTruncation";
+    NodeBuilderFlags[NodeBuilderFlags["WriteArrayAsGenericType"] = 2] = "WriteArrayAsGenericType";
+    NodeBuilderFlags[NodeBuilderFlags["GenerateNamesForShadowedTypeParams"] = 4] = "GenerateNamesForShadowedTypeParams";
+    NodeBuilderFlags[NodeBuilderFlags["UseStructuralFallback"] = 8] = "UseStructuralFallback";
+    NodeBuilderFlags[NodeBuilderFlags["ForbidIndexedAccessSymbolReferences"] = 16] = "ForbidIndexedAccessSymbolReferences";
+    NodeBuilderFlags[NodeBuilderFlags["WriteTypeArgumentsOfSignature"] = 32] = "WriteTypeArgumentsOfSignature";
+    NodeBuilderFlags[NodeBuilderFlags["UseFullyQualifiedType"] = 64] = "UseFullyQualifiedType";
+    NodeBuilderFlags[NodeBuilderFlags["UseOnlyExternalAliasing"] = 128] = "UseOnlyExternalAliasing";
+    NodeBuilderFlags[NodeBuilderFlags["SuppressAnyReturnType"] = 256] = "SuppressAnyReturnType";
+    NodeBuilderFlags[NodeBuilderFlags["WriteTypeParametersInQualifiedName"] = 512] = "WriteTypeParametersInQualifiedName";
+    NodeBuilderFlags[NodeBuilderFlags["MultilineObjectLiterals"] = 1024] = "MultilineObjectLiterals";
+    NodeBuilderFlags[NodeBuilderFlags["WriteClassExpressionAsTypeLiteral"] = 2048] = "WriteClassExpressionAsTypeLiteral";
+    NodeBuilderFlags[NodeBuilderFlags["UseTypeOfFunction"] = 4096] = "UseTypeOfFunction";
+    NodeBuilderFlags[NodeBuilderFlags["OmitParameterModifiers"] = 8192] = "OmitParameterModifiers";
+    NodeBuilderFlags[NodeBuilderFlags["UseAliasDefinedOutsideCurrentScope"] = 16384] = "UseAliasDefinedOutsideCurrentScope";
+    NodeBuilderFlags[NodeBuilderFlags["UseSingleQuotesForStringLiteralType"] = 268435456] = "UseSingleQuotesForStringLiteralType";
+    NodeBuilderFlags[NodeBuilderFlags["NoTypeReduction"] = 536870912] = "NoTypeReduction";
+    NodeBuilderFlags[NodeBuilderFlags["UseInstantiationExpressions"] = 1073741824] = "UseInstantiationExpressions";
+    NodeBuilderFlags[NodeBuilderFlags["OmitThisParameter"] = 33554432] = "OmitThisParameter";
+    NodeBuilderFlags[NodeBuilderFlags["WriteCallStyleSignature"] = 134217728] = "WriteCallStyleSignature";
+    NodeBuilderFlags[NodeBuilderFlags["AllowThisInObjectLiteral"] = 32768] = "AllowThisInObjectLiteral";
+    NodeBuilderFlags[NodeBuilderFlags["AllowQualifiedNameInPlaceOfIdentifier"] = 65536] = "AllowQualifiedNameInPlaceOfIdentifier";
+    NodeBuilderFlags[NodeBuilderFlags["AllowAnonymousIdentifier"] = 131072] = "AllowAnonymousIdentifier";
+    NodeBuilderFlags[NodeBuilderFlags["AllowEmptyUnionOrIntersection"] = 262144] = "AllowEmptyUnionOrIntersection";
+    NodeBuilderFlags[NodeBuilderFlags["AllowEmptyTuple"] = 524288] = "AllowEmptyTuple";
+    NodeBuilderFlags[NodeBuilderFlags["AllowUniqueESSymbolType"] = 1048576] = "AllowUniqueESSymbolType";
+    NodeBuilderFlags[NodeBuilderFlags["AllowEmptyIndexInfoType"] = 2097152] = "AllowEmptyIndexInfoType";
+    NodeBuilderFlags[NodeBuilderFlags["AllowNodeModulesRelativePaths"] = 67108864] = "AllowNodeModulesRelativePaths";
+    NodeBuilderFlags[NodeBuilderFlags["IgnoreErrors"] = 70221824] = "IgnoreErrors";
+    NodeBuilderFlags[NodeBuilderFlags["InObjectTypeLiteral"] = 4194304] = "InObjectTypeLiteral";
+    NodeBuilderFlags[NodeBuilderFlags["InTypeAlias"] = 8388608] = "InTypeAlias";
+    NodeBuilderFlags[NodeBuilderFlags["InInitialEntityName"] = 16777216] = "InInitialEntityName";
+})(NodeBuilderFlags || (NodeBuilderFlags = {}));


NodeBuilderFlags is generated as any here, which removes type safety precisely where the API surface uses it as a parameter type (e.g., signatureToSignatureDeclaration(..., flags?: NodeBuilderFlags)). Consider importing/using the generated typed enum (nodeBuilderFlags.enum.ts) in the API layer, or adjusting generation so #enums/nodeBuilderFlags resolves to the typed enum while still providing a runtime value export.

Suggested change

export var NodeBuilderFlags: any;

(function (NodeBuilderFlags) {

NodeBuilderFlags[NodeBuilderFlags["None"] = 0] = "None";

NodeBuilderFlags[NodeBuilderFlags["NoTruncation"] = 1] = "NoTruncation";

NodeBuilderFlags[NodeBuilderFlags["WriteArrayAsGenericType"] = 2] = "WriteArrayAsGenericType";

NodeBuilderFlags[NodeBuilderFlags["GenerateNamesForShadowedTypeParams"] = 4] = "GenerateNamesForShadowedTypeParams";

NodeBuilderFlags[NodeBuilderFlags["UseStructuralFallback"] = 8] = "UseStructuralFallback";

NodeBuilderFlags[NodeBuilderFlags["ForbidIndexedAccessSymbolReferences"] = 16] = "ForbidIndexedAccessSymbolReferences";

NodeBuilderFlags[NodeBuilderFlags["WriteTypeArgumentsOfSignature"] = 32] = "WriteTypeArgumentsOfSignature";

NodeBuilderFlags[NodeBuilderFlags["UseFullyQualifiedType"] = 64] = "UseFullyQualifiedType";

NodeBuilderFlags[NodeBuilderFlags["UseOnlyExternalAliasing"] = 128] = "UseOnlyExternalAliasing";

NodeBuilderFlags[NodeBuilderFlags["SuppressAnyReturnType"] = 256] = "SuppressAnyReturnType";

NodeBuilderFlags[NodeBuilderFlags["WriteTypeParametersInQualifiedName"] = 512] = "WriteTypeParametersInQualifiedName";

NodeBuilderFlags[NodeBuilderFlags["MultilineObjectLiterals"] = 1024] = "MultilineObjectLiterals";

NodeBuilderFlags[NodeBuilderFlags["WriteClassExpressionAsTypeLiteral"] = 2048] = "WriteClassExpressionAsTypeLiteral";

NodeBuilderFlags[NodeBuilderFlags["UseTypeOfFunction"] = 4096] = "UseTypeOfFunction";

NodeBuilderFlags[NodeBuilderFlags["OmitParameterModifiers"] = 8192] = "OmitParameterModifiers";

NodeBuilderFlags[NodeBuilderFlags["UseAliasDefinedOutsideCurrentScope"] = 16384] = "UseAliasDefinedOutsideCurrentScope";

NodeBuilderFlags[NodeBuilderFlags["UseSingleQuotesForStringLiteralType"] = 268435456] = "UseSingleQuotesForStringLiteralType";

NodeBuilderFlags[NodeBuilderFlags["NoTypeReduction"] = 536870912] = "NoTypeReduction";

NodeBuilderFlags[NodeBuilderFlags["UseInstantiationExpressions"] = 1073741824] = "UseInstantiationExpressions";

NodeBuilderFlags[NodeBuilderFlags["OmitThisParameter"] = 33554432] = "OmitThisParameter";

NodeBuilderFlags[NodeBuilderFlags["WriteCallStyleSignature"] = 134217728] = "WriteCallStyleSignature";

NodeBuilderFlags[NodeBuilderFlags["AllowThisInObjectLiteral"] = 32768] = "AllowThisInObjectLiteral";

NodeBuilderFlags[NodeBuilderFlags["AllowQualifiedNameInPlaceOfIdentifier"] = 65536] = "AllowQualifiedNameInPlaceOfIdentifier";

NodeBuilderFlags[NodeBuilderFlags["AllowAnonymousIdentifier"] = 131072] = "AllowAnonymousIdentifier";

NodeBuilderFlags[NodeBuilderFlags["AllowEmptyUnionOrIntersection"] = 262144] = "AllowEmptyUnionOrIntersection";

NodeBuilderFlags[NodeBuilderFlags["AllowEmptyTuple"] = 524288] = "AllowEmptyTuple";

NodeBuilderFlags[NodeBuilderFlags["AllowUniqueESSymbolType"] = 1048576] = "AllowUniqueESSymbolType";

NodeBuilderFlags[NodeBuilderFlags["AllowEmptyIndexInfoType"] = 2097152] = "AllowEmptyIndexInfoType";

NodeBuilderFlags[NodeBuilderFlags["AllowNodeModulesRelativePaths"] = 67108864] = "AllowNodeModulesRelativePaths";

NodeBuilderFlags[NodeBuilderFlags["IgnoreErrors"] = 70221824] = "IgnoreErrors";

NodeBuilderFlags[NodeBuilderFlags["InObjectTypeLiteral"] = 4194304] = "InObjectTypeLiteral";

NodeBuilderFlags[NodeBuilderFlags["InTypeAlias"] = 8388608] = "InTypeAlias";

NodeBuilderFlags[NodeBuilderFlags["InInitialEntityName"] = 16777216] = "InInitialEntityName";

})(NodeBuilderFlags || (NodeBuilderFlags = {}));

export enum NodeBuilderFlags {

None = 0,

NoTruncation = 1,

WriteArrayAsGenericType = 2,

GenerateNamesForShadowedTypeParams = 4,

UseStructuralFallback = 8,

ForbidIndexedAccessSymbolReferences = 16,

WriteTypeArgumentsOfSignature = 32,

UseFullyQualifiedType = 64,

UseOnlyExternalAliasing = 128,

SuppressAnyReturnType = 256,

WriteTypeParametersInQualifiedName = 512,

MultilineObjectLiterals = 1024,

WriteClassExpressionAsTypeLiteral = 2048,

UseTypeOfFunction = 4096,

OmitParameterModifiers = 8192,

UseAliasDefinedOutsideCurrentScope = 16384,

UseSingleQuotesForStringLiteralType = 268435456,

NoTypeReduction = 536870912,

UseInstantiationExpressions = 1073741824,

OmitThisParameter = 33554432,

WriteCallStyleSignature = 134217728,

AllowThisInObjectLiteral = 32768,

AllowQualifiedNameInPlaceOfIdentifier = 65536,

AllowAnonymousIdentifier = 131072,

AllowEmptyUnionOrIntersection = 262144,

AllowEmptyTuple = 524288,

AllowUniqueESSymbolType = 1048576,

AllowEmptyIndexInfoType = 2097152,

AllowNodeModulesRelativePaths = 67108864,

IgnoreErrors = 70221824,

InObjectTypeLiteral = 4194304,

InTypeAlias = 8388608,

InInitialEntityName = 16777216,

}

andrewbranch · 2026-04-29T19:16:28Z

+	}
+
+	var enclosingDeclaration *ast.Node
+	if params.Location != "" {


Nit: the param should be called EnclosingDeclaration

I'll fix this in the next one

exporting endpoints

6aaf359

Copilot AI review requested due to automatic review settings April 15, 2026 01:36

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Copilot started reviewing on behalf of navya9singh April 15, 2026 03:39 View session

navya9singh requested a review from andrewbranch April 15, 2026 17:12

RyanCavanaugh added this to the TypeScript 7.0 RC milestone Apr 17, 2026

navya9singh added 5 commits April 20, 2026 14:45

Merge branch 'main' of https://github.com/microsoft/typescript-go int…

74348f7

…o navyasingh/updatingExport

Merge branch 'main' of https://github.com/microsoft/typescript-go int…

a1b68b9

…o navyasingh/updatingExport

Merge branch 'main' of https://github.com/microsoft/typescript-go int…

a2f73fc

…o navyasingh/updatingExport

addressing pr comments

ef39ceb

Merge branch 'main' of https://github.com/microsoft/typescript-go int…

21676fc

…o navyasingh/updatingExport

RealColdFry mentioned this pull request Apr 25, 2026

API: additional Checker methods for transpiler consumers (follow-up to #3403) #3610

Open

navya9singh added 3 commits April 28, 2026 14:06

adding more endpoints

66c5058

Merge branch 'main' of https://github.com/microsoft/typescript-go int…

cf22f5e

…o dev/navyasingh/moreEndpoints

fixing lint error

9c80d48

andrewbranch reviewed Apr 28, 2026

View reviewed changes

andrewbranch reviewed Apr 29, 2026

View reviewed changes

andrewbranch requested changes Apr 29, 2026

View reviewed changes

navya9singh added 2 commits April 29, 2026 11:37

Revert "adding more endpoints"

6098f64

This reverts commit 66c5058.

addressing comments

8ebd86c

navya9singh requested a review from andrewbranch April 29, 2026 18:53

andrewbranch requested a review from Copilot April 29, 2026 18:54

Copilot started reviewing on behalf of andrewbranch April 29, 2026 19:07 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

andrewbranch approved these changes Apr 29, 2026

View reviewed changes

navya9singh added this pull request to the merge queue Apr 29, 2026

Merged via the queue into microsoft:main with commit 1b81e8f Apr 29, 2026
25 checks passed

navya9singh deleted the navyasingh/updatingExport branch April 29, 2026 20:14

		@@ -0,0 +1,36 @@
		// Code generated by Herebyfile.mjs generate:enums from internal/nodebuilder/types.go. DO NOT EDIT.

	return nil, fmt.Errorf("%w: invalid parameter index", ErrClientError)
	return nil, fmt.Errorf("%w: invalid parameter index: %d", ErrClientError, params.Index)

-// GetTypeAtPosition returns the type of a parameter at a given index in a signature.
+// GetTypeAtPosition returns the type at the given position within a signature.
+// The pos argument is a signature position (for example, a parameter index), not
+// a source-code position or AST location.

Conversation

navya9singh commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrewbranch left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants