Ensure request cancel is always called#3429
Merged
jakebailey merged 2 commits intomainfrom Apr 16, 2026
Merged
Conversation
andrewbranch
approved these changes
Apr 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a context leak in the LSP server’s request dispatch loop by ensuring per-request cancellation functions are always invoked when a request is finished/removed, which aligns with Go’s requirement to call cancel funcs from WithCancel/WithTimeout to release resources (relevant to the memory spike reported in #3423).
Changes:
- Hoist
cancel context.CancelFuncso it can be invoked during request cleanup. - Ensure
cancel()is called when removing a completed request frompendingClientRequests.
jakebailey
commented
Apr 16, 2026
|
|
||
| // Enqueue the debounced diagnostics refresh | ||
| s.backgroundQueue.Enqueue(debounceCtx, func(ctx context.Context) { | ||
| defer cancel() |
Member
Author
There was a problem hiding this comment.
This code might not call cancelDiagnosticsRefresh and so this could also be dangling. It should be safe to call this here.
andrewbranch
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to be the root cause of #3423. The cancel function from
WithCancel,WithTimeout, etc, must be called no matter what. Normally, this is deferred, but this is trickier code because of how we need to order requests and do cancellation out-of-band.