Handle property access expressions in type node serialization#3633
Merged
Conversation
Member
|
We are missing more stuff from main than I thought from the merge queue bug / outage |
gabritto
approved these changes
Apr 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for serializing PropertyAccessExpression nodes when printing type nodes, enabling QuickInfo and related outputs to correctly display pseudo-types like f<T>.C (fixes #3629).
Changes:
- Handle
ast.KindPropertyAccessExpressioninPrinter.emitTypeNodeby delegating to the property-access emitter. - Update type-node precedence to include
KindPropertyAccessExpression(and adjust grouping ofKindExpressionWithTypeArguments). - Add a new fourslash QuickInfo test + baseline covering generic type paths like
Box<f<string>.C>.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| testdata/baselines/reference/fourslash/quickInfo/quickInfoGenericTypePath.baseline | New baseline capturing QuickInfo output including f<string>.C type paths. |
| internal/printer/printer.go | Enables printing PropertyAccessExpression in type-node serialization. |
| internal/fourslash/tests/quickInfoGenericTypePath_test.go | New fourslash test reproducing and validating the generic type-path QuickInfo scenario. |
| internal/ast/precedence.go | Treats KindPropertyAccessExpression as a non-array type precedence for correct parenthesization behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3629.