Restore #3529#3640
Merged
Merged
Conversation
jakebailey
previously approved these changes
Apr 28, 2026
jakebailey
reviewed
Apr 28, 2026
jakebailey
approved these changes
Apr 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the previously-merged fix from #3529/#3509 so that maybeMappedType again triggers the mapped-type suggestion diagnostic (TS2690) in the appropriate computed-property/type-literal scenario, and updates baselines/triage data accordingly.
Changes:
- Fix
Checker.maybeMappedTypeAST-walk and assignability check to re-enable mapped-type suggestions. - Update reference baseline output for
typeUsedAsTypeLiteralIndexto reflect TS2690 + suggestion text. - Adjust triaged submodule baseline tracking entries (including removal of the now-unneeded triaged diff file).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/checker/checker.go |
Restores maybeMappedType behavior for emitting the mapped-type “Did you mean to use … in …” suggestion. |
testdata/baselines/reference/submodule/compiler/typeUsedAsTypeLiteralIndex.errors.txt |
Updates reference baseline to TS2690 + suggestion text. |
testdata/baselines/reference/submoduleTriaged/compiler/typeUsedAsTypeLiteralIndex.errors.txt.diff |
Removes the now-unnecessary triaged diff (behavior matches reference again). |
testdata/submoduleTriaged.txt |
Updates the triaged list to drop the old entry and add a new one (currently inconsistent). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore #3529 after it got reverted in merge queue bug.