Accept JS declaration emit preserving side effect imports#3756
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Accepts the baseline changes for JS declaration emit behavior in nodeModulesAllowJsExportAssignment across Node16/18/20/nodenext module modes, as discussed in #3552, by moving these diffs from triaged to accepted.
Changes:
- Remove the #3552 entry and associated diffs from
testdata/submoduleTriaged.txt. - Add an accepted note + accept-list entries for the same diffs in
testdata/submoduleAccepted.txt. - Add reference accepted baseline
.js.difffiles capturing the new declaration emit output (export assignment ordering and preserving side-effect imports).
Reviewed changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/submoduleTriaged.txt | Removes the triaged block for #3552 and its associated diff entries. |
| testdata/submoduleAccepted.txt | Adds an accepted rationale and accepts the four nodeModulesAllowJsExportAssignment diffs. |
| testdata/baselines/reference/submoduleAccepted/conformance/nodeModulesAllowJsExportAssignment(module=node16).js.diff | Adds the accepted reference diff for Node16 module mode. |
| testdata/baselines/reference/submoduleAccepted/conformance/nodeModulesAllowJsExportAssignment(module=node18).js.diff | Adds the accepted reference diff for Node18 module mode. |
| testdata/baselines/reference/submoduleAccepted/conformance/nodeModulesAllowJsExportAssignment(module=node20).js.diff | Adds the accepted reference diff for Node20 module mode. |
| testdata/baselines/reference/submoduleAccepted/conformance/nodeModulesAllowJsExportAssignment(module=nodenext).js.diff | Adds the accepted reference diff for nodenext module mode. |
jakebailey
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3552, see discussion there