Skip to content

Accept JS declaration emit preserving side effect imports#3756

Merged
andrewbranch merged 1 commit into
microsoft:mainfrom
andrewbranch:baseline-accept/3552
May 8, 2026
Merged

Accept JS declaration emit preserving side effect imports#3756
andrewbranch merged 1 commit into
microsoft:mainfrom
andrewbranch:baseline-accept/3552

Conversation

@andrewbranch
Copy link
Copy Markdown
Member

Closes #3552, see discussion there

Copilot AI review requested due to automatic review settings May 7, 2026 23:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Accepts the baseline changes for JS declaration emit behavior in nodeModulesAllowJsExportAssignment across Node16/18/20/nodenext module modes, as discussed in #3552, by moving these diffs from triaged to accepted.

Changes:

  • Remove the #3552 entry and associated diffs from testdata/submoduleTriaged.txt.
  • Add an accepted note + accept-list entries for the same diffs in testdata/submoduleAccepted.txt.
  • Add reference accepted baseline .js.diff files capturing the new declaration emit output (export assignment ordering and preserving side-effect imports).

Reviewed changes

Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
testdata/submoduleTriaged.txt Removes the triaged block for #3552 and its associated diff entries.
testdata/submoduleAccepted.txt Adds an accepted rationale and accepts the four nodeModulesAllowJsExportAssignment diffs.
testdata/baselines/reference/submoduleAccepted/conformance/nodeModulesAllowJsExportAssignment(module=node16).js.diff Adds the accepted reference diff for Node16 module mode.
testdata/baselines/reference/submoduleAccepted/conformance/nodeModulesAllowJsExportAssignment(module=node18).js.diff Adds the accepted reference diff for Node18 module mode.
testdata/baselines/reference/submoduleAccepted/conformance/nodeModulesAllowJsExportAssignment(module=node20).js.diff Adds the accepted reference diff for Node20 module mode.
testdata/baselines/reference/submoduleAccepted/conformance/nodeModulesAllowJsExportAssignment(module=nodenext).js.diff Adds the accepted reference diff for nodenext module mode.

@andrewbranch andrewbranch added this pull request to the merge queue May 8, 2026
Merged via the queue into microsoft:main with commit 633af79 May 8, 2026
25 checks passed
@andrewbranch andrewbranch deleted the baseline-accept/3552 branch May 8, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Baselines: export = a reordered; ESM side-effect import replaces export {}

3 participants