Accept CJS exports pattern baseline diffs#3781
Merged
Merged
Conversation
Move diff files from submoduleTriaged/ to submoduleAccepted/ for: - compiler/jsExportAssignmentNonMutableLocation.js.diff - conformance/commonJSImportClassTypeReference.js.diff - conformance/commonJSImportNestedClassTypeReference.js.diff - conformance/jsDeclarationsExportDoubleAssignmentInClosure.js.diff These are intentional changes - nested CJS exports are no longer bound, and there is a new declaration emit error for it. Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CJS exports pattern changes in declaration emit
Accept CJS exports pattern baseline diffs
May 8, 2026
RyanCavanaugh
approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s baseline-tracking metadata to treat several CommonJS (CJS) declaration-emit output diffs as intentionally accepted, reflecting the current Corsa behavior around nested CJS export patterns.
Changes:
- Moved four baseline
.difffiles fromsubmoduleTriagedtosubmoduleAccepted(reference baselines). - Updated
testdata/submoduleAccepted.txtandtestdata/submoduleTriaged.txtto reflect the reclassification. - Added the corresponding accepted baseline diff files under
testdata/baselines/reference/submoduleAccepted/....
Show a summary per file
| File | Description |
|---|---|
| testdata/submoduleTriaged.txt | Removes the CJS declaration-emit diffs from the triaged list. |
| testdata/submoduleAccepted.txt | Adds the CJS declaration-emit diffs to the accepted list under issue #3559. |
| testdata/baselines/reference/submoduleAccepted/compiler/jsExportAssignmentNonMutableLocation.js.diff | Adds accepted baseline diff for compiler case related to CJS export assignment pattern. |
| testdata/baselines/reference/submoduleAccepted/conformance/commonJSImportClassTypeReference.js.diff | Adds accepted baseline diff for conformance CJS import/class type reference behavior. |
| testdata/baselines/reference/submoduleAccepted/conformance/commonJSImportNestedClassTypeReference.js.diff | Adds accepted baseline diff for nested CJS import/class type reference behavior. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsExportDoubleAssignmentInClosure.js.diff | Adds accepted baseline diff for JS declarations export double-assignment-in-closure case. |
Copilot's findings
- Files reviewed: 2/6 changed files
- Comments generated: 0
jakebailey
approved these changes
May 9, 2026
weswigham
approved these changes
May 11, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Member
|
Alas, merge conflict |
Member
|
@copilot resolve the merge conflict |
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Contributor
Author
Resolved the merge conflict in |
jakebailey
approved these changes
May 11, 2026
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
wow, it actually solved the conflict
Member
|
And then we immediately caused another one |
Member
|
@copilot resolve the merge conflict |
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Contributor
Author
jakebailey
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepts baseline diffs for CJS declaration emit changes as intentional. Corsa no longer binds nested JS exports, producing a new
Nested CommonJS export constructs cannot be serialized for declaration emiterror instead.submoduleTriaged/→submoduleAccepted/submoduleAccepted.txt/submoduleTriaged.txtaccordinglyAffected baselines
compiler/jsExportAssignmentNonMutableLocation.js.diffconformance/commonJSImportClassTypeReference.js.diffconformance/commonJSImportNestedClassTypeReference.js.diffconformance/jsDeclarationsExportDoubleAssignmentInClosure.js.diff