Cache alias candidates for symbol accessibility#4102
Open
Zzzen wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR optimizes alias resolution by caching exported-symbol alias candidates per container and per resolved/merged target symbol, reducing repeated scans and redundant sorting.
Changes:
- Added a
Checker-level cache mapping containers to exported-target → candidate-export symbols. - Updated
getAliasForSymbolInContainerto populate and consult the cache. - Avoided unnecessary sorting when there is only a single candidate.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/checker/symbolaccessibility.go | Adds cached lookup/build path for alias candidates keyed by resolved exported target symbols. |
| internal/checker/checker.go | Introduces a new Checker field to store the alias-candidate cache. |
Comment on lines
+361
to
+382
| target := c.getMergedSymbol(c.resolveSymbol(c.getMergedSymbol(symbol))) | ||
| if c.aliasCandidatesByExportedTarget != nil { | ||
| if candidatesByTarget, ok := c.aliasCandidatesByExportedTarget[container]; ok { | ||
| candidates := candidatesByTarget[target] | ||
| if len(candidates) > 0 { | ||
| if len(candidates) > 1 { | ||
| c.sortSymbols(candidates) // _must_ sort exports for stable results - symbol table is randomly iterated | ||
| } | ||
| return candidates[0] | ||
| } | ||
| return nil | ||
| } | ||
| } else { | ||
| c.aliasCandidatesByExportedTarget = make(map[*ast.Symbol]map[*ast.Symbol][]*ast.Symbol) | ||
| } | ||
|
|
||
| candidatesByTarget := make(map[*ast.Symbol][]*ast.Symbol, len(exports)) | ||
| for _, exported := range exports { | ||
| exportedTarget := c.getMergedSymbol(c.resolveSymbol(c.getMergedSymbol(exported))) | ||
| candidatesByTarget[exportedTarget] = append(candidatesByTarget[exportedTarget], exported) | ||
| } | ||
| c.aliasCandidatesByExportedTarget[container] = candidatesByTarget |
| if c.getSymbolIfSameReference(exported, symbol) != nil { | ||
| candidates = append(candidates, exported) | ||
|
|
||
| target := c.getMergedSymbol(c.resolveSymbol(c.getMergedSymbol(symbol))) |
|
|
||
| candidatesByTarget := make(map[*ast.Symbol][]*ast.Symbol, len(exports)) | ||
| for _, exported := range exports { | ||
| exportedTarget := c.getMergedSymbol(c.resolveSymbol(c.getMergedSymbol(exported))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4101