Consistently name VS types with prefix VS#4173
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Mechanical rename to consistently use the Go-style VS prefix (instead of Vs) for all Visual Studio-specific types, functions, fields, and a test name. The change updates the LSP proto generator script and its generated output, plus all consumers in the language service, server, fourslash harness, and tests.
Changes:
- Rename generator entries (and regenerate
lsp_generated.go) so VS-specific structures, params/responses, and theVSReferenceKindenum use theVSprefix;ClassifiedTextRun/ClassifiedTextElementbecomeVSClassifiedTextRun/VSClassifiedTextElement. - Update all Go call sites (
internal/ls/*,internal/lsp/server.go,internal/fourslash/*) to the new identifiers, includingProvideVSReferences,combineVSReferences,handleVSOnAutoInsert, andVerifyBaselineVSFindAllReferences. - Update one test function/comment (
TestRaceHasChangesVSUpdateWatchState) for naming consistency.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/lsp/lsproto/_generate/generate.mts | Rename VS structures/enums in the generator source |
| internal/lsp/lsproto/lsp_generated.go | Regenerated output reflecting renamed types/methods/enum values |
| internal/lsp/server.go | Update handler registrations and capability struct usage to new names |
| internal/ls/findallreferences.go | Rename ProvideVsReferences/symbolAndEntriesToVsReferences and switch to VSClassifiedText* types |
| internal/ls/crossproject.go | Rename combineVsReferences and field accesses on the renamed response type |
| internal/ls/autoinsert.go | Use renamed VSOnAutoInsert* params/response types |
| internal/ls/signaturehelp.go | Use VSClassifiedTextElement/VSClassifiedTextRun |
| internal/ls/displaypartswriter.go | Update runs field and GetRuns signature to VSClassifiedTextRun |
| internal/fourslash/fourslash.go | Rename VerifyBaselineVsFindAllReferences and update VS field/type accesses |
| internal/fourslash/tests/constructorFindAllReferences1VS_test.go | Call renamed verifier |
| internal/fourslash/tests/findAllRefsForDefaultExportVS_test.go | Call renamed verifier |
| internal/fourslash/tests/findAllRefsInheritedProperties1VS_test.go | Call renamed verifier |
| internal/fourslash/tests/findReferencesAcrossMultipleProjectsVS_test.go | Call renamed verifier |
| internal/fourslash/tests/tsxFindAllReferences1VS_test.go | Call renamed verifier |
| internal/vfs/vfswatch/vfswatch_race_test.go | Rename test function and its doc comment to VS casing |
navya9singh
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed in review; prefix these so we know they are for VS, and then use the Go-style
VSprefix as we had in previous code.