-
Notifications
You must be signed in to change notification settings - Fork 730
Fix detection of super statement in visiting constructor #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This would probably benefit from an emit test (see the neighboring file for this transform), |
|
@microsoft-github-policy-service agree |
|
For some more context:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This to me seems like the evidence that this change is right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with @rbuckton and there's apparently another cause to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with @rbuckton and there's apparently another cause to this.
|
There are two issues at play here. One is that |
|
I've put up the fix for these issues in #679 |
Fixes #540