feat: add reference resolver tests #561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree |
Author
|
@jakebailey @KeoFoxy Thanks for adding the .idea folder to .gitignore |
jakebailey
reviewed
Mar 13, 2025
Author
|
@rbuckton Any chance for the review yet? |
SoulPancake
commented
Mar 18, 2025
| const identifier = "some-identifier" | ||
|
|
||
| func TestNewReferenceResolver(t *testing.T) { | ||
| t.Parallel() |
Author
There was a problem hiding this comment.
I can perhaps add a
//nolint:paralleltest
Member
|
Thanks, but I don't think we need these; all of this is extremely extensively tested through the thousands of compiler tests we have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some coverage for reference resolver in this
along with that I have added .idea dir to .gitignore as intelliJ Goland is incredibly common among Go developers.
Let me know your thoughts about this