Completely replace JSDocNonNullableType parsing with OptionalType #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34 parsing of OptionalTypeNode. Previously,
T?was always parsed as JSDocNullableType and then parseTupleElementType would throw away the nullable type node and construct a OptionalTypeNode. NowT?is always an optional type. The code is slightly simpler.I didn't change the way it's parsed, even though it's not really in an obvious location. I really wanted to parse
T?only in tuple position, insideparseTupleElementType, but by that pointT?has already been parsed as the start of a malformed conditional type. There might be a way to move the construction of OptionalTypeNode to conditional type parsing, but that's not much better than where it is now.