Skip generating ClientSettings for internal clients#10086
Merged
JoshLove-msft merged 4 commits intomicrosoft:mainfrom Mar 19, 2026
Merged
Conversation
JoshLove-msft
requested review from
ShivangiReja,
christothes,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
…for internal clients Bug 1: When no auth is configured, the internal constructor accepted an authenticationPolicy parameter but never included it in the pipeline policies. Fixed by checking only authPolicyParam != null instead of requiring authFields != null too. Bug 2: When ClientOptions is internal, skip generating ClientSettings entirely rather than generating a settings class with accessibility mismatches. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JoshLove-msft
force-pushed
the
jolov/fix-auth-policy-and-settings-accessibility
branch
from
c4ca659 to
360ee5c
Compare
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
…cy-and-settings-accessibility
The client-level public check is sufficient; if the client is internal, settings are already skipped. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JoshLove-msft
changed the title
Verify that ClientSettings is null when the client is customized to be internal, in both CanChangeClientAccessibility and CanChangeClientOptionsAccessibility tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jorgerangel-msft
approved these changes
Mar 19, 2026
commit: |
Contributor
|
No changes needing a change description found. |
JoshLove-msft
deleted the
jolov/fix-auth-policy-and-settings-accessibility
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client is internal (e.g., via customization), skip generating the \ClientSettings\ type entirely. There is no need to generate a public settings class for an internal client.
Changes