Skip internal/private custom constructors for settings and schema gen…#10253
Merged
JoshLove-msft merged 1 commit intomicrosoft:mainfrom Apr 2, 2026
Merged
Conversation
…eration Only public custom constructors should be considered when discovering additional client parameters for settings properties, BindCore binding, and ConfigurationSchema.json generation. Internal/private constructors contain infrastructure parameters (HttpPipeline, AzureKeyCredential, sync tokens, etc.) that are not suitable for configuration binding. Fixes build failures in Azure SDK caused by generating bindings for abstract types and internal infrastructure types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JoshLove-msft
requested review from
ShivangiReja,
christothes,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
commit: |
Contributor
|
No changes needing a change description found. |
jsquire
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eration
Only public custom constructors should be considered when discovering additional client parameters for settings properties, BindCore binding, and ConfigurationSchema.json generation. Internal/private constructors contain infrastructure parameters (HttpPipeline, AzureKeyCredential, sync tokens, etc.) that are not suitable for configuration binding.
Fixes build failures in Azure SDK caused by generating bindings for abstract types and internal infrastructure types.