Skip to content

fix(spector): handle matchers in query param validation#10259

Merged
tadelesh merged 4 commits intomainfrom
copilot/fix-date-time-query-matching
Apr 7, 2026
Merged

fix(spector): handle matchers in query param validation#10259
tadelesh merged 4 commits intomainfrom
copilot/fix-date-time-query-matching

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026

  • Fix query param matcher handling (resolveMatchers: false + isMatcher branch)
  • Add regression tests for query param matcher preservation
  • Apply the same fix to header validation: pass resolveMatchers: false and add isMatcher(value) branch
  • Add regression test for header matcher preservation

Copilot AI and others added 2 commits April 3, 2026 02:14
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/97f0d4fc-38c9-455c-b99d-f9dd980c6658

Co-authored-by: weidongxu-microsoft <53292327+weidongxu-microsoft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/97f0d4fc-38c9-455c-b99d-f9dd980c6658

Co-authored-by: weidongxu-microsoft <53292327+weidongxu-microsoft@users.noreply.github.com>
Comment thread packages/spector/src/app/app.ts
…gh expandDyns

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/3d8e85a8-9e45-4d55-9f8c-7882641b3c27

Co-authored-by: weidongxu-microsoft <53292327+weidongxu-microsoft@users.noreply.github.com>
@weidongxu-microsoft
Copy link
Copy Markdown
Contributor

weidongxu-microsoft commented Apr 3, 2026

For PR #10011

agent session https://github.com/microsoft/typespec/tasks/467970f4-8e4b-4bab-b0fb-6d9774b72753?author=weidongxu-microsoft (analyze is on my local Copilot CLI)

tested locally by directly modify the js file in test project node_modules

Comment thread packages/spec-api/test/match-engine.test.ts
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 3, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/spec-api@10259
npm i https://pkg.pr.new/@typespec/spector@10259

commit: 006ef06

…gression test

Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/05805cb9-1d23-42fd-8b80-fd06410b09dc

Co-authored-by: weidongxu-microsoft <53292327+weidongxu-microsoft@users.noreply.github.com>
@azure-sdk
Copy link
Copy Markdown
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@tadelesh tadelesh added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit 6d7d7da Apr 7, 2026
42 checks passed
@tadelesh tadelesh deleted the copilot/fix-date-time-query-matching branch April 7, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spector Issues related to spector and the spec sets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants