fix: skip ConfigurationSchema.json generation for non-public clients#10284
Merged
JoshLove-msft merged 1 commit intomicrosoft:mainfrom Apr 7, 2026
Merged
Conversation
ConfigurationSchemaGenerator was generating schemas for clients that had been made internal by visitors (e.g., management RestClientVisitor). ClientSettings was set during construction when DeclarationModifiers was still Public, and the generator only checked ClientSettings != null. Added a DeclarationModifiers.HasFlag(Public) check so only clients that are still public after visitors have run are included in the schema. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JoshLove-msft
requested review from
ShivangiReja,
christothes,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
ArcturusZhang
approved these changes
Apr 7, 2026
jorgerangel-msft
approved these changes
Apr 7, 2026
commit: |
Contributor
|
No changes needing a change description found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigurationSchemaGenerator was generating schemas for clients that had been made internal by visitors (e.g., management RestClientVisitor). ClientSettings was set during construction when DeclarationModifiers was still Public, and the generator only checked ClientSettings != null.
Added a DeclarationModifiers.HasFlag(Public) check so only clients that are still public after visitors have run are included in the schema.