Fix node sea build with newer node#10345
Merged
timotheeguerin merged 1 commit intomicrosoft:mainfrom Apr 10, 2026
Merged
Conversation
Contributor
|
No changes needing a change description found. |
Collaborator
|
You can try these changes here
|
timotheeguerin
requested review from
AlitzelMendez,
bterlson,
chrisradek,
markcowl and
witemple-msft
as code owners
markcowl
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like node now is able to bundle single excutable without an external tool but as part of this is broke the existing pipeline. This should fix it until we figure out what we want to do.
Either we only keep building the executable directly on latest node and skip on other or we keep that until node 22 is dropped