[http-client-java] Report error when clientRequired is set to false

[Copilot]

• Add new diagnostic client-required-false to lib.ts
• Move isPropertyRequired from utils.ts to a private method in CodeModelBuilder class in code-model-builder.ts
• Report error via reportDiagnostic when clientRequired is false
• Add necessary imports (getClientOptions, DecoratedType) to code-model-builder.ts
• Update imports in code-model-builder.ts to remove isPropertyRequired from utils
• Build and test the emitter changes (all 15 tests pass)
• Add changelog entry
• Remove clientRequired=false test case from client-option.tsp (it now produces an error)
• Regenerate ClientOptionClient.java, ClientOptionAsyncClient.java, and ClientRequiredsImpl.java (filter is now required)

[weidongxu-microsoft]

@copilot

please remove this line (as now it is error)
https://github.com/microsoft/typespec/blob/copilot/fix-client-required-property-issue/packages/http-client-java/generator/http-client-generator-test/tsp/client-option.tsp#L29

and run Generate.ps1 to regenerate the code (see instruction on how to run it)

[github-actions]

All changed packages have been documented.

• ✅ @typespec/http-client-java

Show changes

@typespec/http-client-java - internal ✏️

Add test case for withRelativeNextLink, FlattenUnknownModel, FlattenReadOnlyModel scenario.

@typespec/http-client-java - fix ✏️

Report an error when clientRequired is set to false on a property.

[github-actions]

All changed packages have been documented.

• ✅ @typespec/http-client-java

Show changes

@typespec/http-client-java - fix ✏️

Report an error when clientRequired is set to false on a property.

[Copilot]

@copilot

please remove this line (as now it is error)
...

Done in commit f80d2d7. Removed line 29 (clientRequired=false for filter) from client-option.tsp and regenerated the affected files. The filter parameter is now required in the generated Java client — it moved from being an optional nullable field to a required first parameter in post(String filter, ClientRequiredRequest body).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• archive.eclipse.org
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/typespec/typespec/packages/http-client-java/generator org.codehaus.plexus.classworlds.launcher.Launcher clean install --no-transfer-progress -T 1C -f ./generator/pom.xml (dns block)
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/typespec/typespec/packages/http-client-java/generator org.codehaus.plexus.classworlds.launcher.Launcher clean install --no-transfer-progress -T 1C -f ./generator/pom.xml m/main.tsp --optbash roject-root}/tsp--norc de/node/bin/sh roject-root}/tsp-output/10381595compile (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[azure-sdk]

You can try these changes here

🛝 Playground	🌐 Website	🛝 VSCode Extension