fix(playground): line-level diff highlighting and reduce typing freezes#10442
Merged
JoshLove-msft merged 2 commits intoApr 22, 2026
Merged
Conversation
Bug 1: The CSS rule for '.playground-changed-line' was defined inside a .module.css file and imported as a side-effect. Vite/CSS Modules does not emit :global() rules from a side-effect import, so the class was never in the built stylesheet and Monaco decorations were invisible. Renamed to a plain .css file and removed the :global() wrapper. Additionally, 'highlightChanges' was gated by 'emitterOptions.newChangeDiff' which the shipping website never sets. Default it to true so the feature is live out of the box (callers can still opt out). Bug 2: While a compile is in progress, any additional onDidChangeContent-triggered recompile now marks a pending recompile flag and bails out instead of stacking work. When the current compile completes we run a single trailing recompile. This doesn't fix the fundamental main-thread block from synchronous compilation, but prevents queuing redundant blocking compiles while the user is typing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JoshLove-msft
requested review from
AlitzelMendez,
bterlson,
chrisradek,
markcowl,
timotheeguerin and
witemple-msft
as code owners
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Collaborator
|
You can try these changes here
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
timotheeguerin
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1: The CSS rule for '.playground-changed-line' was defined inside a .module.css file and imported as a side-effect. Vite/CSS Modules does not emit :global() rules from a side-effect import, so the class was never in the built stylesheet and Monaco decorations were invisible. Renamed to a plain .css file and removed the :global() wrapper.
Additionally, 'highlightChanges' was gated by 'emitterOptions.newChangeDiff' which the shipping website never sets. Default it to true so the feature is live out of the box (callers can still opt out).
Bug 2: While a compile is in progress, any additional onDidChangeContent-triggered recompile now marks a pending recompile flag and bails out instead of stacking work. When the current compile completes we run a single trailing recompile. This doesn't fix the fundamental main-thread block from synchronous compilation, but prevents queuing redundant blocking compiles while the user is typing.