Skip to content

[python] Revert wrong code to avoid overwrite customized code when generation-subdir is set #10545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyyc merged 3 commits into from
Apr 29, 2026
+11 −2
Merged

[python] Revert wrong code to avoid overwrite customized code when generation-subdir is set #10545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
018e5c6
revert wrong code about generation-subdir
msyyc Apr 29, 2026
40f2703
revert wrong code about generation-subdir
msyyc Apr 29, 2026
65ebbbb
update
msyyc Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/revert-wrong-code-2026-3-29-13-46-47.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@typespec/http-client-python"
---

Revert wrong code to avoid overwrite customized code when generation-subdir is set
6 changes: 4 additions & 2 deletions packages/http-client-python/generator/pygen/codegen/serializers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,10 @@ def serialize(self) -> None:
# When generation-subdir is configured, generated code goes into a subdirectory
# (e.g., _generated/). We also need an __init__.py in the parent namespace dir
# so that the package is discoverable by find_packages() / pip install.
if self.code_model.options.get("generation-subdir"):
root_dir = self.code_model.get_root_dir()
root_dir = self.code_model.get_root_dir()
if self.code_model.options.get("generation-subdir") and not self.read_file(
root_dir / Path("__init__.py")
):
self.write_file(
root_dir / Path("__init__.py"),
general_serializer.serialize_pkgutil_init_file(),
Expand Down
Loading