Fix unreliable code fix application by switching to codeAction/resolve #10618
Merged
timotheeguerin merged 2 commits intoMay 7, 2026
Merged
Conversation
microsoft-github-policy-service
Bot
added
the
compiler:core
commit: |
Contributor
|
All changed packages have been documented.
|
Collaborator
|
You can try these changes here
|
timotheeguerin
changed the title
timotheeguerin
changed the title
codeAction/resolve
timotheeguerin
requested review from
AlitzelMendez,
RodgeFu,
bterlson,
chrisradek,
markcowl and
witemple-msft
as code owners
markcowl
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3389
Code fixes would silently fail when a recompilation completed between the user seeing a fix and clicking it, because the diagnostic index was cleared on each compile.
This switches from the legacy command-based flow (
executeCommand) to the LSPcodeAction/resolvepattern edits are resolved at interaction time and embedded directly in theCodeAction, eliminating the race with recompilation. The diagnostic index is also now swapped atomically instead of being cleared eagerly.