fix(http-server-csharp): numeric literal properties in @error models emit correct constructor parameter type#10716
Draft
Copilot wants to merge 2 commits into
Draft
fix(http-server-csharp): numeric literal properties in @error models emit correct constructor parameter type#10716Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
4 tasks
…teral properties in error model constructors Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/172760bb-1724-46d4-966b-e8e1ed0aaecc Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CS1763 invalid constructor for @error model
fix(http-server-csharp): numeric literal properties in @error models emit correct constructor parameter type
May 18, 2026
Member
There was a problem hiding this comment.
@markcowl can we wait for the csharp alloy PR to merged?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@errormodels with numeric literal–typed properties (e.g.status: 404) generatedobject status = 404in the constructor signature, which is illegal in C# (CS1763: a reference-type default may only benull). The property itself was correctly emitted asint, making the intra-class typing inconsistent.Root cause
getExceptionConstructorDataresolved constructor parameter types viagetCSharpType(program, prop.type). For aNumberliteral, that function returns the abstractnumericscalar mapping —object— rather than the concrete numeric type.Fix
service.ts: Whenprop.type.kind === "Number", usefindNumericType(prop.type)(already used bygetTypeInfofor property declarations) to get the correct C# type (intordouble). All other type kinds continue throughgetCSharpTypeunchanged.Before / after
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)telemetry.astro.build/usr/bin/node node /home/REDACTED/work/typespec/typespec/website/node_modules/.bin/../astro/bin/astro.mjs build sh k/ty�� ebsite/src/conte--llmstxt ture n-schema/node_mo../../website/src/content/docs/docs/emitters/openapi3/reference . ce n/node sh n-sc�� tspd --enable-experimental gen-extern-signature . .json .2_tmp_4732_0/node_modules/pnpm/dist/node-gyp-bin/node --no-emit iptables n-schema/referendoc node(dns block)If you need me to access, download, or install something from one of these locations, you can either: