Add style guide #1430
Merged
Add style guide #1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
allenjzhang,
bterlson,
daviwil,
markcowl and
nguerrera
as code owners
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/1430/ Check the website changes at https://cadlwebsite.z1.web.core.windows.net/prs/1430/ |
mikekistler
reviewed
Dec 13, 2022
Member
mikekistler
left a comment
mikekistler
left a comment
There was a problem hiding this comment.
Looks good but there are a few details I think we could add.
allenjzhang
reviewed
Dec 15, 2022
docs/introduction/style-guide.md
Outdated
|
|
||
| <!-- prettier-ignore --> | ||
| ```cadl | ||
| // bad |
timotheeguerin
commented
Dec 15, 2022
nguerrera
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1341