Skip to content

Conversation

@tjprescott
Copy link
Member

@tjprescott tjprescott commented Apr 21, 2023

Closes #1167.

  • Remove duplicate-response error
  • Update openapi3 emitter as needed to support unblocked scenarios
  • Refactor shared routes logic to eliminate duplicate code paths.

@github-actions
Copy link
Contributor

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/1845/

Website: https://cadlwebsite.z1.web.core.windows.net/prs/1845/

@tjprescott tjprescott force-pushed the http/removeDuplicateResponse branch from e628c40 to cd8afe2 Compare April 21, 2023 19:54
@tjprescott tjprescott marked this pull request as ready for review April 21, 2023 22:15
@tjprescott tjprescott force-pushed the http/removeDuplicateResponse branch 2 times, most recently from ab28806 to 05f38f8 Compare April 21, 2023 22:33
@tjprescott tjprescott force-pushed the http/removeDuplicateResponse branch from 05f38f8 to faeaeb3 Compare April 24, 2023 17:17
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. How does this affect the autorest emitter?

@tjprescott
Copy link
Member Author

Looks good. How does this affect the autorest emitter?

It would presumably fall under this:
Azure/typespec-azure#2438

In other words, it's not supported.

@tjprescott tjprescott merged commit ed76d4f into microsoft:main Apr 25, 2023
@tjprescott tjprescott deleted the http/removeDuplicateResponse branch April 25, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove duplicate response errors for unions

2 participants