Skip to content

Conversation

@rahimi-ali
Copy link
Contributor

Fix the link syntax and target

@github-actions
Copy link
Contributor

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2317/

Website: https://cadlwebsite.z1.web.core.windows.net/prs/2317/

Copy link
Contributor

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the linter needs to be executed to pass ci. Most likely this is a subtle change in the linter for markdown files

@daviwil daviwil requested a review from markcowl August 30, 2023 11:43
@daviwil
Copy link
Contributor

daviwil commented Aug 30, 2023

@rahimi-ali @markcowl I fixed the issue preventing CI from passing but it seems that it's now triggered the CLA notice. Let me know if you have trouble signing it (or if you can't), @rahimi-ali and I can reopen this PR myself. Thanks!

@rahimi-ali
Copy link
Contributor Author

@rahimi-ali please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@daviwil daviwil dismissed markcowl’s stale review August 30, 2023 12:11

Problem has been resolved

@daviwil
Copy link
Contributor

daviwil commented Aug 30, 2023

Thanks for the contribution @rahimi-ali!

@daviwil daviwil merged commit c42321c into microsoft:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants