Skip to content

Fix the self type module resolution issue #4689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaryGao wants to merge 5 commits into from
Closed

Fix the self type module resolution issue #4689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5436576
Update the fix
MaryGao Oct 11, 2024
55dc245
Merge branch 'main' into fix-self-module-resolution-issue
MaryGao Oct 11, 2024
ed769ca
Refactor code a little
MaryGao Oct 11, 2024
8d6cf9f
Merge branch 'fix-self-module-resolution-issue' of https://github.com…
MaryGao Oct 11, 2024
c160a4e
Update the changelog
MaryGao Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/fix-self-module-resolution-issue-2024-9-11-13-9-23.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@typespec/compiler"
---

Fix module resolution issue for self type module
7 changes: 2 additions & 5 deletions packages/compiler/src/module-resolver/module-resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,8 @@ export async function resolveModule(
const pkgFile = resolvePath(dir, "package.json");
if (!(await isFile(host, pkgFile))) continue;
const pkg = await readPackage(host, pkgFile);
if (pkg.name === name) {
return loadPackage(dir, pkg);
} else {
return undefined;
}
if (pkg.name !== name) continue;
return loadPackage(dir, pkg);
Copy link
Member

@timotheeguerin timotheeguerin Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the way it is done now is the correct way according the the node resolution spec, you only lookup to the first parent package.json for resolving self. What is the use case?

Copy link
Member Author

@MaryGao MaryGao Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case happened in our cadl-ranch test where during generation our emitter dist code is in the same folder with tsp code and emitter is not released yet.

}
return undefined;
}
Expand Down