Skip to content

Update ClientPipelineApi, HttpMessageApi abstraction#4816

Merged
live1206 merged 16 commits intomicrosoft:mainfrom
live1206:update-create-message
Oct 31, 2024
Merged

Update ClientPipelineApi, HttpMessageApi abstraction#4816
live1206 merged 16 commits intomicrosoft:mainfrom
live1206:update-create-message

Conversation

@live1206
Copy link
Copy Markdown
Contributor

@live1206 live1206 commented Oct 22, 2024

  • Remove unused ClientPipelineApi.CreateMessage
  • Add HttpRequestOptionsApi to ClientPipelineApi.Send(Async)
  • Replace HttpMessageApi.ResponseClassifier with HttpMessageApi.ApplyResponseClassifier
  • Make abstraction more generic

This fix is needed for below issues of Azure plugin:
Azure/azure-sdk-for-net#46899
Azure/azure-sdk-for-net#46900
Azure/azure-sdk-for-net#46901
Azure/azure-sdk-for-net#46902

@microsoft-github-policy-service microsoft-github-policy-service Bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Oct 22, 2024
@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp.ClientModel

@live1206 live1206 marked this pull request as ready for review October 25, 2024 05:19
@live1206 live1206 changed the title Update ClientPipelineApi.CreateMessage abstraction Update ClientPipelineApi abstraction Oct 25, 2024
@live1206
Copy link
Copy Markdown
Contributor Author

Corresponding changes in Azure Plugin: Azure/azure-sdk-for-net#46835

@live1206 live1206 changed the title Update ClientPipelineApi abstraction Update ClientPipelineApi, HttpMessageApi abstraction Oct 30, 2024
@live1206 live1206 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into microsoft:main with commit fe8f3f1 Oct 31, 2024
@live1206 live1206 deleted the update-create-message branch October 31, 2024 04:43
swatkatz pushed a commit to swatkatz/typespec that referenced this pull request Nov 5, 2024
- Remove unused `ClientPipelineApi.CreateMessage`
- Add `HttpRequestOptionsApi` to `ClientPipelineApi.Send(Async)`
- Replace `HttpMessageApi.ResponseClassifier` with
`HttpMessageApi.ApplyResponseClassifier`
- Make abstraction more generic

This fix is needed for below issues of Azure plugin:
Azure/azure-sdk-for-net#46899
Azure/azure-sdk-for-net#46900
Azure/azure-sdk-for-net#46901
Azure/azure-sdk-for-net#46902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants