Skip to content

Conversation

@iscai-msft
Copy link
Member

@iscai-msft iscai-msft commented Jan 21, 2025

@azure-sdk
Copy link
Collaborator

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 21, 2025

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs 🛝 VSCode Extension

Copy link
Contributor

@msyyc msyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR influence the way to install dependencies for test framework, please also make a PR which contains similar changes in autorest.python repo.

@iscai-msft
Copy link
Member Author

@msyyc there are differences between install_requires and requirements.txt (see stackoverflow here). I think we should reconsider how we're treating setup.py and install_reqs, but I'm ok to peel this out into a separate PR and change it when we migrate to pyproject.toml here

Copy link
Contributor

@msyyc msyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me now.

@iscai-msft iscai-msft added this pull request to the merge queue Jan 24, 2025
Merged via the queue into microsoft:main with commit 981ab79 Jan 24, 2025
35 checks passed
@iscai-msft iscai-msft deleted the python/addDependabot branch January 24, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add dependabot for @typespec/http-client-python in typespec repo

4 participants