-
Notifications
You must be signed in to change notification settings - Fork 331
[WIP][http-client-js]Enable e2e cases #6551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
|
|
||
| declare type String_2 = string; | ||
| export { String_2 as String } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the _N suffix issue.
|
|
||
| export declare function dateDeserializer(date?: string | null): Date; | ||
|
|
||
| export declare function dateRfc3339Serializer(date?: Date | null): string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not export internal interfaces.
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
|
|
||
| export declare function encodeUint8Array(value: Uint8Array | undefined | null, encoding: BufferEncoding): string | undefined; | ||
|
|
||
| export declare class ExplicitBodyClient { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not expose internal clients.
| declare interface PutOptions_8 extends OperationOptions { | ||
| } | ||
|
|
||
| declare interface PutOptions_9 extends OperationOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated names with suffix _N issue.
|
Hi @@MaryGao. Your PR has had no update for 30 days and it is marked as a stale PR. If it is not updated within 30 days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
|
Hi @@MaryGao. The PR will be closed since the PR has no update for 60 days. If this is still relevant please reopen. |
Missing features