Remove literalContext
#6744
Merged
Remove literalContext
#6744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
ArcturusZhang
force-pushed
the
try-to-remove-literal-context
branch
from
9f1d990 to
a13e170
Compare
Contributor
|
No changes needing a change description found. |
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. @typespec/http-client-csharp |
Member
Author
yep this is in progress which contains quite a few changes |
6 tasks
JoshLove-msft
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Azure/autorest.csharp#4746
We have a very complicated logic to give names to literal types (or constant types from TCGC) so that we could convert them into extensible enums in our generated code.
But actually, TCGC already has the ability to make up a name for the constant types, which in most cases is the same as the one we have.
Therefore, to simplify our emitter, we should remove this
literalContextand related logic, just use the name we have from TCGC.During making this change, some requirements come up for TCGC as well, I will open issues, and fix them in TCGC in a near future.
Issues created for TCGC: