Skip to content

Fix playground crash on no target #6753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Fix playground crash on no target #6753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91ccf9f
Fix playground crash on no target
timotheeguerin Mar 28, 2025
23e495f
Create fix-playground-crash-no-target-2025-2-28-17-18-31.md
timotheeguerin Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chronus/changes/fix-playground-crash-no-target-2025-2-28-17-18-31.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
changeKind: fix
packages:
- "@typespec/playground"
---

Guard against diagnostic reported without a target
8 changes: 8 additions & 0 deletions packages/playground/src/react/diagnostic-list/diagnostic-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,18 @@ const DiagnosticItem: FunctionComponent<DiagnosticItemProps> = ({ diagnostic, on
};

const DiagnosticTargetLink = memo(({ target }: { target: DiagnosticTarget | typeof NoTarget }) => {
if (target === undefined) {
return (
<span title="Diagnostic didn't report a target. This is a bug on the emitter.">
No target
</span>
);
}
if (typeof target === "symbol") {
return <span></span>;
}
const location = getSourceLocation(target);

const file = location.file.path === "/test/main.tsp" ? "" : `${location.file.path}:`;
const { line, character } = location.file.getLineAndCharacterOfPosition(location.pos);
return (
Expand Down
Loading