Skip to content

Comments

http-client-java, patch 0.3.1, fix java version check#6851

Merged
weidongxu-microsoft merged 5 commits intomicrosoft:mainfrom
weidongxu-microsoft:http-client-java_patch-fix-java-version-check
Apr 4, 2025
Merged

http-client-java, patch 0.3.1, fix java version check#6851
weidongxu-microsoft merged 5 commits intomicrosoft:mainfrom
weidongxu-microsoft:http-client-java_patch-fix-java-version-check

Conversation

@weidongxu-microsoft
Copy link
Contributor

@weidongxu-microsoft weidongxu-microsoft commented Apr 3, 2025

bug fix on "javac" version pattern like below:

javac 24

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:java Issue for the Java client emitter: @typespec/http-client-java label Apr 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 3, 2025

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@weidongxu-microsoft weidongxu-microsoft force-pushed the http-client-java_patch-fix-java-version-check branch from 67a532b to 1bc92eb Compare April 3, 2025 09:55
@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review April 3, 2025 10:00
Copy link
Member

@XiaofeiCao XiaofeiCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, add a comment, e.g. "javac 24" -> 24

@weidongxu-microsoft
Copy link
Contributor Author

nit, add a comment, e.g. "javac 24" -> 24

Thanks. Added 7f91a81

@weidongxu-microsoft weidongxu-microsoft force-pushed the http-client-java_patch-fix-java-version-check branch from d87c8e2 to 7f91a81 Compare April 3, 2025 10:46
@weidongxu-microsoft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

auto-merge was automatically disabled April 3, 2025 10:48

Pull request was closed

@weidongxu-microsoft weidongxu-microsoft changed the title http-client-java, patch fix java version check http-client-java, patch 0.3.1, fix java version check Apr 3, 2025
@weidongxu-microsoft weidongxu-microsoft added this pull request to the merge queue Apr 4, 2025
Merged via the queue into microsoft:main with commit 6b391b0 Apr 4, 2025
25 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the http-client-java_patch-fix-java-version-check branch April 4, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:java Issue for the Java client emitter: @typespec/http-client-java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants