Fix the paging method compilation issue by prepending the client name#6853
Closed
ArcturusZhang wants to merge 1 commit intomicrosoft:mainfrom
Closed
Fix the paging method compilation issue by prepending the client name#6853ArcturusZhang wants to merge 1 commit intomicrosoft:mainfrom
ArcturusZhang wants to merge 1 commit intomicrosoft:mainfrom
Conversation
ArcturusZhang
requested review from
JoshLove-msft,
jorgerangel-msft,
m-nash and
nisha-bhatia
as code owners
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
Contributor
|
No changes needing a change description found. |
| bool isAsync) | ||
| { | ||
| return new CollectionResultDefinition(client, operation, type, isAsync); | ||
| var resultKey = new ClientCollectionResultKey(client, operation, type, isAsync); |
Contributor
There was a problem hiding this comment.
I don't think we need this cache as we only create one instance per combo.
Contributor
|
Closing in favor of #6854 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6852